We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent refactoring creates a new instance of the adblock engine and so it doesn't preserve the tags which were set on startup.
template<typename T> LoadDATFileDataResult<T> LoadDATFileData( const base::FilePath& dat_file_path) { DATFileDataBuffer buffer; GetDATFileData(dat_file_path, &buffer); std::unique_ptr<T> client; client = std::make_unique<T>(); <------ Problem
On startup the tags are not applied. However if you go into settings and manually toggle them it worked.
Things like Facebook are not loaded
Things like Facebook should be loaded
Always 0.67.x and 0.68.x
The text was updated successfully, but these errors were encountered:
Verification passed on
Verified steps from the description.
Reproduced the issue on 0.67.79
Verified that is fixed:
Verified passed with
Sorry, something went wrong.
No branches or pull requests
Description
Recent refactoring creates a new instance of the adblock engine and so it doesn't preserve the tags which were set on startup.
On startup the tags are not applied.
However if you go into settings and manually toggle them it worked.
Steps to Reproduce
Actual result:
Things like Facebook are not loaded
Expected result:
Things like Facebook should be loaded
Reproduces how often:
Always 0.67.x and 0.68.x
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: