Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor loadFromJson from RapidJSON to base::JSONReader #6351

Closed
tmancey opened this issue Oct 8, 2019 · 3 comments · Fixed by brave/brave-core#4045
Closed

Refactor loadFromJson from RapidJSON to base::JSONReader #6351

tmancey opened this issue Oct 8, 2019 · 3 comments · Fixed by brave/brave-core#4045
Assignees
@tmancey
Labels
dev-concern feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.3.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 8, 2019

No description provided.

@tmancey tmancey added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. dev-concern labels Oct 8, 2019
@tmancey tmancey self-assigned this Oct 8, 2019
@tmancey tmancey mentioned this issue Oct 8, 2019
Closed
3 tasks
@tmancey tmancey mentioned this issue Nov 21, 2019
Merged
32 tasks
@tmancey
Copy link
Contributor Author

tmancey commented Nov 21, 2019

Properties have been renamed to prepare for #6352 after this ticket has been merged

@tmancey tmancey added CI/skip and removed CI/skip labels Nov 26, 2019
@tmancey tmancey added this to the 1.3.x - Nightly milestone Dec 2, 2019
@btlechowski
Copy link

@tmancey Is this issue QA/Yes or QA/No?

@tmancey tmancey added the QA/Yes label Dec 18, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jan 17, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)

Upgrade paths

  • Installed 1.2.42 and confirmed the following states:
  1. Rewards On, Ads On, AC On —> Upgrade to 1.3.x —> states preserved
  2. Rewards On, Ads Off, AC On —> Upgrade to 1.3.x —> states preserved
  3. Rewards On, Ads On, AC Off —> Upgrade to 1.3.x —> states preserved
  4. Rewards On, Ads Off, AC Off —> Upgrade to 1.3.x —> states preserved
  5. Rewards Off but had been on previously —> Upgrade to 1.3.x —> state preserved
  6. Rewards never On —> state preserved
  • Installed 1.2.42 and confirmed the following data is set up:
  1. Rewards On, anon wallet has balance, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data —> Upgrade to 1.3.x —> data is preserved
  2. Rewards On, KYC’d Uphold user wallet connected, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data —> Upgrade to 1.3.x —> data is preserved

Clean install checks:

  • Installed 1.3.x and confirmed the following states:
  1. Rewards OFF. Close and relaunch Brave. State preserved.
  2. Rewards On, and then toggle off. Close and relaunch Brave. State preserved.
  3. Rewards On, Ads On, AC On. Close and relaunch Brave. States preserved.
  4. Rewards On, Ads Off, AC On. Close and relaunch Brave. States preserved.
  5. Rewards On, Ads On, AC Off. Close and relaunch Brave. States preserved.
  6. Rewards On, Ads Off, AC Off. Close and relaunch Brave. States preserved.
  • Installed 1.3.x and confirmed the following data is set up:
  1. Rewards On, anon wallet has balance, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data. Close and relaunch Brave. Data is preserved. (Note, encountered issue Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526 as noted below, so Tips panel did not have data)
  2. Rewards On, KYC’d Uphold user wallet connected, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data. Close and relaunch Brave. Data is preserved.

Verification passed on

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Upgrade paths

  • Installed 1.2.42 and confirmed the following states:
  1. Rewards On, Ads On, AC On —> Upgrade to 1.3.x —> states preserved
  2. Rewards On, Ads Off, AC On —> Upgrade to 1.3.x —> states preserved
  3. Rewards On, Ads On, AC Off —> Upgrade to 1.3.x —> states preserved
  4. Rewards On, Ads Off, AC Off —> Upgrade to 1.3.x —> states preserved
  5. Rewards Off but had been on previously —> Upgrade to 1.3.x —> state preserved
  6. Rewards never On —> state preserved
  • Installed 1.2.42 and confirmed the following data is set up:
  1. Rewards On, anon wallet has balance, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data —> Upgrade to 1.3.x —> data is preserved
  2. Rewards On, KYC’d Uphold user wallet connected, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data —> Upgrade to 1.3.x —> data is preserved

Clean install checks:

  • Installed 1.3.x and confirmed the following states:
  1. Rewards OFF. Close and relaunch Brave. State preserved.
  2. Rewards On, and then toggle off. Close and relaunch Brave. State preserved.
  3. Rewards On, Ads On, AC On. Close and relaunch Brave. States preserved.
  4. Rewards On, Ads Off, AC On. Close and relaunch Brave. States preserved.
  5. Rewards On, Ads On, AC Off. Close and relaunch Brave. States preserved.
  6. Rewards On, Ads Off, AC Off. Close and relaunch Brave. States preserved.
  • Installed 1.3.x and confirmed the following data is set up:
  1. Rewards On, anon wallet has balance, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data. Close and relaunch Brave. Data is preserved. (Note, encountered issue Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526 as noted below, so Tips panel did not have data)
  2. Rewards On, KYC’d Uphold user wallet connected, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data. Close and relaunch Brave. Data is preserved.

Verification passed on

Brave 1.3.96 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

Upgrade paths

  • Installed 1.2.42 and confirmed the following states:
  1. Rewards On, Ads On, AC On —> Upgrade to 1.3.x —> states preserved
  2. Rewards On, Ads Off, AC On —> Upgrade to 1.3.x —> states preserved
  3. Rewards On, Ads On, AC Off —> Upgrade to 1.3.x —> states preserved
  4. Rewards On, Ads Off, AC Off —> Upgrade to 1.3.x —> states preserved
  5. Rewards Off but had been on previously —> Upgrade to 1.3.x —> state preserved
  6. Rewards never On —> state preserved
  • Installed 1.2.42 and confirmed the following data is set up:
  1. Rewards On, anon wallet has balance, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data —> Upgrade to 1.3.x —> data is preserved
  2. Rewards On, KYC’d Uphold user wallet connected, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data —> Upgrade to 1.3.x —> data is preserved

Clean install checks:

  • Installed 1.3.x and confirmed the following states:
  1. Rewards OFF. Close and relaunch Brave. State preserved.
  2. Rewards On, and then toggle off. Close and relaunch Brave. State preserved.
  3. Rewards On, Ads On, AC On. Close and relaunch Brave. States preserved.
  4. Rewards On, Ads Off, AC On. Close and relaunch Brave. States preserved.
  5. Rewards On, Ads On, AC Off. Close and relaunch Brave. States preserved.
  6. Rewards On, Ads Off, AC Off. Close and relaunch Brave. States preserved.
  • Installed 1.3.x and confirmed the following data is set up:
  1. Rewards On, anon wallet has balance, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data. Close and relaunch Brave. Data is preserved. (Note, encountered issue Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526 as noted below, so Tips panel did not have data)
  2. Rewards On, KYC’d Uphold user wallet connected, Ads panel has data, AC panel has data, Monthly Contributions panel has data, Tips panel has data. Close and relaunch Brave. Data is preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor loadFromJson from RapidJSON to base::JSONReader brave/brave-core
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya