Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom text isn't translated for Disclaimer message #6533

Closed
srirambv opened this issue Oct 17, 2019 · 3 comments
Closed

Custom text isn't translated for Disclaimer message #6533

srirambv opened this issue Oct 17, 2019 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

Follow up to #6289. Custom text implemented as part of #6485 isn't translated

Steps to Reproduce

  1. Install component 0.1.17
  2. Set device locale to French
  3. Disclosure message isn't translated
  4. Choose a type to set up: text isn't translated
  5. Back button text isn't translated on create/restore wallet pages
  6. Password info message on create/restore wallet pages aren't translated

Actual result:

Dislosure message
image
Choose a type to set up:
image
Back & password info message on create page
image
Back & password info message on restore page
image

Expected result:

All custom text should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux

Ethereum component version 0.1.17

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bbondy
Copy link
Member

bbondy commented Dec 15, 2020

I believe this was fixed via a localization order. Works for me. I tried on Release channel too.
Capture d’écran 2020-12-15 à 3 09 39 PM

I'm not sure at what point it was fixed but I'll just put it in the Beta Milestone so it gets verified by QA.

@bbondy bbondy closed this as completed Dec 15, 2020
@bbondy bbondy added this to the 1.19.x - Beta milestone Dec 15, 2020
@srirambv
Copy link
Contributor Author

srirambv commented Jan 5, 2021

This doesn't seem to fix all the custom text. Custom text on Create Account & Restore Account still has untranslated text

CryptoWallets-Untranslated.Text.mp4

Will log a follow up issue for the untranslated text in create and restore account page.

@srirambv
Copy link
Contributor Author

srirambv commented Jan 5, 2021

Verification passed on

Brave 1.19.74 Chromium: 87.0.4280.101 (Official Build) beta (64 Bit) 1.19.74 Chromium: 87.0.4280.101 (Official Build) beta (x86_64) 1.19.74 Chromium: 87.0.4280.101 (Official Build) beta (64 Bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807} 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807} 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 10 OS Version 2009 (Build 9042.685) macOS Version 10.15.7 (Build 19H2) Linux
Component 1.0.24 1.0.24 1.0.24
Screenshot Screenshot 2021-01-05 at 10 23 14 Screenshot 2021-01-05 at 10 23 14 Screenshot 2021-01-05 at 10 26 05

Logged #13367 as a follow-up issue for missing translations

@srirambv srirambv changed the title Custom text isn't translated Custom text isn't translated for Disclaimer message Jan 5, 2021
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants