Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webtorrent viewer doesn't import the poppins font #6961

Open
fmarier opened this issue Nov 16, 2019 · 2 comments
Open

webtorrent viewer doesn't import the poppins font #6961

fmarier opened this issue Nov 16, 2019 · 2 comments
Labels
feature/webtorrent Label for webtorrent related issues priority/P4 Planned work. We expect to get to it "soon".

Comments

@fmarier
Copy link
Member

fmarier commented Nov 16, 2019 •
edited
Loading

While every other user of muli.css in brave/components/ also imports/requires poppins.css, it appears to be missing from the webtorrent viewer.

Is that a mistake?
@fmarier fmarier mentioned this issue Nov 16, 2019
Merged
32 tasks
@bsclifton bsclifton added the feature/webtorrent Label for webtorrent related issues label Nov 19, 2019
@btlechowski
Copy link

The webtorrent actually uses Poppins and Moli fonts.

image

image

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 7 Service Pack 1 (Build 7601.24530)

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 10, 2020
@fmarier
Copy link
Member Author

fmarier commented Jan 10, 2020

Thanks for confirming @btlechowski, it does look like it should have been imported. We're probably seeing the default fonts there where the stylesheet is requesting the Poppins font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/webtorrent Label for webtorrent related issues priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fmarier @bsclifton @rebron @btlechowski