Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads not being blocked on 9to5google.com and 9to5mac.com #7400

Closed
thanuj10 opened this issue Dec 16, 2019 · 10 comments
Closed

Ads not being blocked on 9to5google.com and 9to5mac.com #7400

thanuj10 opened this issue Dec 16, 2019 · 10 comments
Assignees
Labels
closed/fixed-by-component-update closed/works-for-me feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@thanuj10
Copy link

thanuj10 commented Dec 16, 2019

Description

Ads are not being blocked on https://www.9to5google.com and https://www.9to5mac.com

Steps to Reproduce

  1. Visit 9to5mac.com/9to5google.com
  2. Wait for page to load fully
  3. Ads are also loaded and visible.

Actual result:

Ads are also loaded along with the webpage on its homepage and its subsequent articles.

Expected result:

Ads are blocked on both homepage and article pages.

Reproduces how often:

Very Easily reproduced.

Brave version (brave://version info)

  • Brave | 1.4.25 Chromium: 79.0.3945.79 (Official Build) nightly (64-bit)
  • Revision | 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{Add balance check #916}
  • OS | Windows 10 OS Version 1903 (Build 18362.418)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not tested
  • Can you reproduce this issue with the beta channel? Not Tested
  • Can you reproduce this issue with the dev channel? Not Tested
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

N/A

@srirambv srirambv added the feature/shields/adblock Blocking ads & trackers with Shields label Dec 16, 2019
@srirambv
Copy link
Contributor

cc: @ryanbr issue happens on release version too

@ryanbr
Copy link

ryanbr commented Dec 16, 2019

These ads aren't easy to remove, but will be fixed in our cosmetic/ubo stuff. See this related thread;
https://www.wilderssecurity.com/threads/ublock-a-lean-and-fast-blocker.365273/page-166#post-2878614

@kjozwiak
Copy link
Member

kjozwiak commented Jan 7, 2020

+1 from myself. Seeing this on all the current channels including 1.2.41 Chromium: 79.0.3945.88 which is the latest release.

@Wolfenstein98k
Copy link

Using latest mobile Brave (1.7.0), confirmed as still a bug.

@ryanbr
Copy link

ryanbr commented Jan 24, 2020

Have been testing this, seems to be a limitation in Chrome. Having the same issue with uBo+Chrome.. Firefox+uBo seems to be okay. (on the Desktoip here)

Also a few details: https://old.reddit.com/r/uBlockOrigin/comments/el4ng5/ads_on_9to5googlecom/fdg3xit/

@Wolfenstein98k
Copy link

Wolfenstein98k commented Jan 24, 2020

Thanks ^

In the context of mobile - I've tested this with Firefox, with uBlock Origin installed as mobile add-on, and the ads are blocked. There also appears to be no WW redirect.

But with Brave, same mobile and connection, the WW redirect is forced every time and the ads show every time. Definitely a Brave issue.

EDIT: on desktop, no issue with Chrome + uBlock Origin. Blocks well. Cannot test Brave on this PC though.

I disagree with that Reddit link... I think the issue is solely Brave's blocking tools, because I can successfully dodge the ads with everything (+uBlock Origin) EXCEPT Brave.

@ryanbr
Copy link

ryanbr commented Jan 24, 2020

Possibly more movement, a new filter suggested:

9to5google.com,9to5mac.com,9to5toys.com,dronedj.com,electrek.co,marketrealist.com##+js(set, String.prototype.charCodeAt, trueFunc)

https://www.reddit.com/r/uBlockOrigin/comments/el4ng5/ads_on_9to5googlecom/ffek56d/

I'll see how this works for us, if it doesn't I'll logged a issue report.

@ryanbr
Copy link

ryanbr commented Jan 24, 2020

We need to support ##+js(set,...) to fix this site.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 14, 2020
@rebron
Copy link
Collaborator

rebron commented Feb 14, 2020

cc: @ryanbr Looks like this issue is fixed in release/beta/etc. Not sure if you addressed this one already.

@ryanbr
Copy link

ryanbr commented Jul 5, 2020

Everything should working now @thanuj10 Just re-checked. site is clean of ads.

@ryanbr ryanbr closed this as completed Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/fixed-by-component-update closed/works-for-me feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

6 participants