-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on exit with sync enabled after closing tor window #7459
Comments
This is a regression introduced in 1.1.x. Reproduced on
Uploaded Crash Report ID 102dfd61c9d51388 (Local Context: 122782ce-1bad-4833-8c81-b81f2387e1a9) Reproduced on
Uploaded Crash Report ID 9cac187a5e9b8405 (Local Context: 57fd5d33-bcdf-443f-b0e1-5694c73af721) Reproduced on
Uploaded Crash Report ID 4297e486d6d05602 (Local Context: 70e3049c-b8e7-4a9f-a5e8-6ebb0dc30693) |
Looks like the following are the two crash signatures: Linux crashes @btlechowski reported above:
Win crashes @btlechowski reported above:
|
cc: @yrliou |
Reproduced with the following steps:
Crash Report: |
OTR profile would return nullptr for BookmarkUndoService, we should be able to fix this acting the same as OTR profile. |
Tried today - cannot reproduce, maybe sync v1 issue. Closing. |
The combination of Sync and Tor crashes Brave on exit.
Reproduces on all channels (1.1.x, 1.2.x, 1.3.x, 1.4.x)
Does not reproduce on 1.0.x.
Steps to Reproduce
Hamburger Menu->Exit
or close Brave withx
Actual result:
Crash on Exit
After relaunching Brave, user is prompted to
Restore pages?
Crash dump id: 92d41f84b9805f7c
Expected result:
No crash
Reproduces how often:
100% repro rate
Brave version (brave://version info)
cc @rebron @bsclifton @brave/legacy_qa @darkdh @AlexeyBarabash @riastradh-brave @tomlowenthal
The text was updated successfully, but these errors were encountered: