Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance auditing using Lighthouse #815

Closed
bsclifton opened this issue Aug 23, 2018 · 23 comments
Closed

Performance auditing using Lighthouse #815

bsclifton opened this issue Aug 23, 2018 · 23 comments
Labels

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#9719

(This might only be applicable to WebUI pages?)

https://developers.google.com/web/tools/lighthouse/ can probably be run on Brave's HTML resources

@bsclifton bsclifton added this to the Backlog milestone Aug 23, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@jonathansampson
Copy link
Contributor

Note that Lighthouse presently doesn't appear to work in Brave. It appears to hang while warming up:

image

This step takes, at most, a couple seconds in Chrome.

audit-with-lighthouse

@Brave-Matt
Copy link

+1 from Community: https://community.brave.com/t/googles-pagespeed-insights-tester-throws-error-when-run-in-brave-browser/44904/2

@Brave-Matt
Copy link

@katiekatsup
Copy link

katiekatsup commented Mar 14, 2019

Also experiencing this issue on the latest (stable) release of Brave. Seems to also hang on "Cancelling..." when attempting to close it.

Edit: Also experiencing this issue in the Dev release.

@katiekatsup
Copy link

As a quick-fix for others running into this issue, installing the Lighthouse plugin and using that seems to work well: https://chrome.google.com/webstore/detail/lighthouse/blipmdconlkpinefehnmjammfjpmpbjk/

@peterjaap
Copy link

+1 would love to have the Lighthouse Audit work since the plugin doesn't offer a trace.

@imtbl
Copy link

imtbl commented Jul 26, 2019

+1 Would like this as well.

@ChrisB85
Copy link

+1 :)

@julianmejio
Copy link

+1

@agarzola
Copy link

I’d like to stay subscribed to this issue to learn about actual updates regarding the bug, but all of these +1 emails are unnecessary noise. To everyone finding this issue:

  • If you want to “upvote” an issue, I suggest reacting with a 👍 to the issue description.
  • If you want to be notified of new comments and updates on the issue, click the Subscribe button near the bottom of the right hand sidebar.

Thanks!

@ghost
Copy link

ghost commented Aug 16, 2019

I'd love to see this fixed! If there's any kind of help that I can provide, let me know! ☀️

@lucadonnoh
Copy link

I had to redownload chrome because of this :(

@jumde jumde self-assigned this Sep 19, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Sep 24, 2019
@bsclifton
Copy link
Member Author

Closing in favor of #3199

This was intended for us to run on our internal pages. Since our UI is no longer HTML/CSS/JavaScript (after moving to Brave Core), this is less applicable

Please give #3199 a +1 if you'd like to see the Lighthouse / Audit feature fixed in Brave (I believe it's hanging if you try on your own pages)

@bsclifton bsclifton added closed/duplicate Issue has already been reported and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 5, 2019
@Varvus
Copy link

Varvus commented Nov 14, 2019

+1

@agarzola
Copy link

Please react with a 👍 on the original ticket description to express your interest in this ticket. If you want to be notified of updates on this ticket, use the Subscribe button at the bottom of the sidebar on this ticket.

@florent-haffner
Copy link

Issue still there...

@bsclifton
Copy link
Member Author

@nelth-fr are you enabling Remote Debugging on brave://settings/privacy?

@smathy
Copy link

smathy commented Mar 6, 2020

Nailed it, thanks @bsclifton

@peterjaap
Copy link

@bsclifton I don't have that option under Privacy?

@Jos512
Copy link

Jos512 commented Mar 31, 2020

Thank you @bsclifton ! Finally got it working with your suggestion, thanks! 🙂


@peterjaap The option is there, but in the Dutch version of Brave it's called "Foutopsporing op afstand":

brave-remote-debugging-dutch

@peterjaap
Copy link

@Jos512 thanks, but my Brave is in English. I just needed to upgrade 🤦‍♂️

@saifhalila
Copy link

just enable remote debugging in Brave Settings.

remote-dubugging-Brave

@stopyransky
Copy link

what if i still get above error when doing lighthouse audit but the option is removed ? #1736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests