Update to new version creates a new people profile

[srirambv]

Description

Update to new version creates a new people profile

Steps to Reproduce

1. Create 2 user profile on 0.54.1 (I had two general and work)
2. Have work profile active and check for update from chrome://settings/help
3. Click Relaunch to update to new version
4. Browser relaunched with a new profile Person 1 instead of work profile which was active and downloaded the update

Actual result:

Update to new version creates a new people profile

Expected result:

Should not create a new profile and instead relaunch using the existing profile

Reproduces how often:

100% on upgrade from 0.54.1 to 0.54.2 with two profiles

Brave version (about:brave info)

Brave	0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision	9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS	Windows
JavaScript	V8 6.9.427.14
Flash	(Disabled)

Reproducible on current release:

N/A

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

@brave/legacy_qa Need to verify this on next update
cc: @bbondy

[Brave-Matt]

I had a new person profile created for me after update but my previous profile/session data has been deleted - or at least Brave can't seem to locate it.

[simonhong]

Hmm, I can't reproduce this with test update server.

Test step:

1. Install older version(69.0.54.0) with BraveBrowserDevSetup.exe installer
2. Create many profiles - Test Profile1 and Test Profile2 and use it both
3. Close all windows except Test Profile2 window
4. Update newer version(70.0.55.1) from settings/help page and relaunch by relaunch button
5. Checked Test Profile2 is used in relaunched window

I did above test on user and admin mode.
@srirambv Does my steps have different point from your steps?

[srirambv]

@simonhong am not sure if renaming the profiles without the Profile word makes a difference! that's the only thing different from your steps and the one i reported.

[srirambv]

moving to 1.x backlog until stub installer is able to point to a specific release to test upgrade scenarios

[simonhong]

I'm closing this issue. Feel free to reopen when this happens again.

[kjozwiak]

@srirambv mind giving this another go and see if you can still reproduce? Please feel free to move it back to the backlog and labelling as needed if this still seems to be an issue.