Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing bookmarks from Safari appears successful but fails - follow up to 2710 #8537

Closed
LaurenWags opened this issue Mar 4, 2020 · 1 comment

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #2710

While testing above issue I am not getting the prompt from brave/brave-core#4530

On further inspection, it looks like maybe only a text update (brave/brave-core#4815) to the above PR was uplifted, not the code for the prompt? See https://github.com/brave/brave-core/commits/1.5.x

Steps to Reproduce

  1. Use 1.5.107
  2. Attempt to import from safari

Actual result:

Screen Shot 2020-03-04 at 5 50 42 PM

Expected result:

Since full disk access is not enabled for Beta, I expected the prompt from brave/brave-core#4530

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.107 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? no

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @bsclifton @kjozwiak @rebron

@LaurenWags
Copy link
Member Author

need to wait for 1.5.108 or above for testing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant