Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify web pages under cache-control for Brave Ads #9021

Closed
tmancey opened this issue Apr 4, 2020 · 1 comment · Fixed by brave/brave-core#5157
Closed

Classify web pages under cache-control for Brave Ads #9021

tmancey opened this issue Apr 4, 2020 · 1 comment · Fixed by brave/brave-core#5157

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 4, 2020

Classify web pages under cache-control for Brave Ads. URL/content is not persisted and only used for page classification

Test Cases

Ensure that websites using the no-store directive for cache-control are being classified. Example outlined via brave/brave-core#5157 (comment).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 20, 2020

Verification passed on

Brave 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Reproduced the issue in 1.7.95, pages were not classified for https://www.microsoft.com/en-ca/ using no-store directive for cache-control
[2572:14816:0420/145147.181:INFO:ads_impl.cc(476)] OnTabUpdated.IsFocused for tab id: 4 and url: https://www.microsoft.com/en-ca/
[2572:14816:0420/145147.207:INFO:client.cc(668)] Successfully saved client state
  • Ensured that visiting https://www.microsoft.com/en-ca/ classified the website correctly in 1.7.98
[4268:9448:0420/155642.600:INFO:ads_impl.cc(874)] Successfully classified page at https://www.microsoft.com/en-ca/ as technology & computing-software. Winning category over time is technology & computing-software
[4268:9448:0420/155642.600:INFO:ads_impl.cc(710)] Site visited https://www.microsoft.com/en-ca/, previous tab url was 
[4268:9448:0420/155642.610:INFO:client.cc(668)] Successfully saved client state

Verification passed on

Brave 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Linux
  • Verified visiting site with cache-control set to no-store gets classified correctly and triggers an ad
    image

Verified passed with

Brave 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-04-20 at 8 45 30 AM

[5743:775:0420/084909.705279:INFO:ads_impl.cc(874)] Successfully classified page at https://www.microsoft.com/en-us/ as technology & computing-software. Winning category over time is technology & computing-software
[5743:775:0420/084909.706194:INFO:ads_impl.cc(710)] Site visited https://www.microsoft.com/en-us/, previous tab url was chrome://newtab/
  • Confirmed page classification was used to determine an ad notification to be shown:
[5743:775:0420/085123.729437:INFO:ads_impl.cc(1177)] Serving ad from categories:
[5743:775:0420/085123.729666:INFO:ads_impl.cc(1179)]   technology & computing-software
[5743:775:0420/085123.729817:INFO:ads_impl.cc(1179)]   technology & computing-windows
[5743:775:0420/085123.729962:INFO:ads_impl.cc(1179)]   technology & computing-technology & computing
[5743:775:0420/085123.735870:INFO:client.cc(668)] Successfully saved client state
[5743:775:0420/085123.736552:INFO:ads_impl.cc(1197)] No eligible ads found in categories:
[5743:775:0420/085123.736753:INFO:ads_impl.cc(1199)]   technology & computing-software
[5743:775:0420/085123.736914:INFO:ads_impl.cc(1199)]   technology & computing-windows
[5743:775:0420/085123.737069:INFO:ads_impl.cc(1199)]   technology & computing-technology & computing
[5743:775:0420/085123.737223:INFO:ads_impl.cc(1230)] Serving ad from parent categories:
[5743:775:0420/085123.737375:INFO:ads_impl.cc(1232)]   technology & computing
[5743:775:0420/085123.742233:INFO:ads_impl.cc(1285)] Found 82 eligible ads
[5743:775:0420/085123.742650:INFO:ads_impl.cc(1534)] Ad notification shown:
  uuid: 28eee79f-1f57-4751-abdb-dd1fdf1f47b8
  parentUuid: f6d2edc0-07f1-447b-8a53-cd21cd8f3f52
  creativeInstanceId: 92d57815-0263-46ee-a65d-93b87199fdb2
  creativeSetId: 8b5b74a2-657f-4973-a022-c73056c6e5ea
  category: technology & computing
  title: Amazon Warehouse Deals
  body: Deep Discounts on Open-box and Used Electronics
  targetUrl: https://www.amazon.com/s/?me=A2L77EE7U53NWQ&rh=i:merchants,n:172282&ie=UTF8&ref_=assoc_tag_ph_1384415829684&_encoding=UTF8&camp=1789&creative=9325&linkCode=pf4&tag=bravesoftware-20&linkId=700100c5d1cf73235620adfa2939f50e
[5743:775:0420/085123.742847:INFO:ad_notifications.cc(296)] Saving notifications state
[5742:775:0420/085123.744682:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: 92d57815-0263-46ee-a65d-93b87199fdb2
  creativeSetId: 8b5b74a2-657f-4973-a022-c73056c6e5ea
  category: technology & computing
  targetUrl: https://www.amazon.com/s/?me=A2L77EE7U53NWQ&rh=i:merchants,n:172282&ie=UTF8&ref_=assoc_tag_ph_1384415829684&_encoding=UTF8&camp=1789&creative=9325&linkCode=pf4&tag=bravesoftware-20&linkId=700100c5d1cf73235620adfa2939f50e
  confirmationType: view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants