Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rewards panel #920

Closed
NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#459
Closed

Add rewards panel #920

NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#459
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Add rewards panel that is opened when you click on BAT logo in url bar
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Sep 2, 2018 •
edited
Loading

blocked on #669

@NejcZdovc NejcZdovc mentioned this issue Sep 2, 2018
Closed
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 3, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Sep 3, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, Releasable builds 0.55.x Sep 5, 2018
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned ryanml Sep 25, 2018
@NejcZdovc NejcZdovc mentioned this issue Sep 25, 2018
Merged
11 tasks
@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2018 •
edited by btlechowski
Loading

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified the welcome note is shown on rewards panel when rewards isn't enabled
  • Verified wallet info is shown on rewards panel when rewards is enabled
  • Verified the publisher name is shown on the rewards panel when on a site
  • Verified no publisher name is shown on the rewards panel when on a media site like YouTube

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Rewards panel brave/brave-core
6 participants
@bbondy @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski