Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binance tweaks for protocol handler #9449

Closed
bbondy opened this issue Apr 24, 2020 · 1 comment · Fixed by brave/brave-core#5353
Closed

Binance tweaks for protocol handler #9449

bbondy opened this issue Apr 24, 2020 · 1 comment · Fixed by brave/brave-core#5353
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.8.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Apr 24, 2020 •
edited
Loading

This is a tracking issue for implementing some review feedback on the protocol handler for Binance oauth.

Steps for QA to retest:

  • Test an oauth flow from each OS, i.e. Connect to the .com widget
    • Test from an account that has 2FA enabled.
    • Test from an account that is does not have 2FA enabled.
  • Close the browser, make sure it is still connected.
@bbondy bbondy added the QA/No label Apr 24, 2020
@bbondy bbondy added this to the 1.10.x - Nightly milestone Apr 24, 2020
@bbondy bbondy self-assigned this Apr 24, 2020
@bbondy bbondy mentioned this issue Apr 24, 2020
Merged
32 tasks
@srirambv srirambv added QA/Yes and removed QA/No labels Apr 28, 2020
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1809 (Build 17763.1158)
  • Verified Oauth flows works on an account with 2FA enabled
  • Verified Oauth flows works on an account with 2FA disabled
  • Verified widget state is retained between browser restarts

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified Oauth flows works on an account with 2FA enabled
  • Verified Oauth flows works on an account with 2FA disabled
  • Verified widget state is retained between browser restarts

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Linux
  • Verified Oauth flows works on an account with 2FA enabled
  • Verified Oauth flows works on an account with 2FA disabled
  • Verified widget state is retained between browser restarts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Various Binance widget tweaks brave/brave-core
3 participants
@bbondy @kjozwiak @srirambv