Audit server responses #9666

NejcZdovc · 2020-05-07T06:17:11Z

We should audit all server responses.

Create response folder and move all parsing of responses into this folder
Create per feature files (like we have them in requests
We need to make sure that every param is validated accordingly (meaning can it be empty or not, is it correct format, etc)

emerick · 2020-06-18T14:31:53Z

@husobee will provide info on HTTP response codes (thank you!)

LaurenWags · 2020-08-17T17:41:33Z

Marked as QA/Blocked pending additional test plan information (requested from @NejcZdovc )

GeetaSarvadnya · 2020-08-20T15:50:38Z

Verification passed on


Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

(Note: As disscussed with @LaurenWags I have covered the regression testing on rewards)

Wallet funded via UGP grants alone

Wallet funded via KYC'd uphold alone

Wallet balance =(Ad grants+KYC'd uphold)

Blocked due to [Desktop] user funds do not move to Uphold - follow up to 8428 #11298

Wallet balance =(UGP+KYC'd uphold)

Wallet funded via Restored wallet or anon depostited wallet

Wallet balance =(UGP+Deposited BAT)

Wallet balance =(Deposited BAT+KYC'd Uphold wallet )

Verified Restored wallet balance is moved to uphold card
Verified wallet status is Verified in brave://rewards-internals
Verified the test steps from verified KYC'd wallet and which are working as expected

Upgrade test

Verified wallet balance is not lost after upgrade
Verified pubs added in AC table are retained after upgrade
Verified Rewards summary is retained after upgrade
Verified pubs can be added/removed after upgrade
Verified pubs can be removed from BR panel and can be added again
Verified pubs added in AC table can be excluded and re-added
Turn OFF rewards switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
Turn OFF AC switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
Turn OFF Ads switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.

Verification passed on

Brave	1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.14.6 (Build 18G3020)

Wallet funded via VG (UGP grant) only

Verified wallet status is Not connected in brave://rewards-internals
Verified checkmark is shown in BR panel as well as in Tipping banner for verified pubs
Verified custom banner shown (when applicable) for verified publishers
Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
Verified one-time tips and monthly tips processed successfully
Verified AC is working fine for verified pubs (added 3 pubs in AC table)
Verified wallet summary is displayed correctly
Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
Verified rewards summary isn't lost after browser restart
Verified able to tip verified pubs when AC is turned off

Wallet funded via Uphold only

Verified wallet status is Verified in brave://rewards-internals
Verified checkmark is shown in BR panel as well as in Tipping banner for KYC'd pubs
Verified checkmark is shown in BR panel, tipping banners for connected publishers
Verified KYC'd publishers do not display any messaging on panel and tip banners
Verified connected publishers display appropriate messaging on panel and tip banners
Verified custom banner shown (when applicable) for verified publishers
Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
Verified one-time tips and monthly tips processed successfully
Verified AC is working fine for verified pubs (added 3 pubs in AC table)
Verified AC is triggered for connected pubs (e.g DDG)
Verified one-time tips sent for connected pubs isn't displayed in tips panel as expected (shows in pending table)
Verified recurring tips for a connected publisher is going into pending contribution list after AC
Verified wallet summary is displayed correctly
Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
Verified transactions are listed correctly in Uphold Recent Activity section
Verified rewards summary isn't lost after browser restart
Verified able to tip verified pubs when AC is turned off

Upgrade Checks

Verified wallet balance is not lost after upgrade
Verified pubs added in AC table are retained after upgrade
Verified Rewards summary is retained after upgrade
Verified pubs can be added to AC list after upgrade
Verified pubs added in AC table can be excluded and re-added
Turn OFF rewards switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
Turn OFF AC switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
Turn OFF Ads switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.

Verification passed on

Brave	1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	Ubuntu 18.04 LTS

Wallet funded via UGP grants alone

Wallet funded via KYC'd uphold alone

Wallet balance =(Ad grants+KYC'd uphold)

Blocked due to [Desktop] user funds do not move to Uphold - follow up to 8428 #11298

Wallet balance =(UGP+KYC'd uphold)

Wallet balance =(UGP+Deposited BAT)

Wallet balance =(Deposited BAT+KYC'd Uphold wallet )

Verified Restored wallet balance is moved to uphold card
Verified wallet status is Verified in brave://rewards-internals
Verified the test steps from verified KYC'd wallet and which are working as expected

Upgrade test

Verified wallet balance is not lost after upgrade
Verified pubs added in AC table are retained after upgrade
Verified Rewards summary is retained after upgrade
Verified pubs can be added/removed after upgrade
Verified pubs can be removed from BR panel and can be added again
Verified pubs added in AC table can be excluded and re-added
Turn OFF rewards switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
Turn OFF AC switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.
Turn OFF Ads switch in 1.12.x and upgrade to 1.13.x and verified that the switch state is retained and it can be enabled.

srirambv · 2020-08-31T11:54:12Z

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

Verified the following scenarios:
Wallet funded via UGP grants alone
- Verified wallet status is Not connected in brave://rewards-internals
- Verified checkmark is shown in BR panel as well as in Tipping banner for verified pubs
- Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
- Verified checkmark is shown in Monthly statement for AC, Monthly contributions and One-time tips for verified pubs
- Verified one-time tips and monthly tips processed successfully
- Verified AC is working fine for verified pubs (added more than 3 pubs in AC table)
- Verified wallet summary is displayed correctly
- Verified wallet summary is showing the correct stats for One-time tip, monthly tip and AC
- Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
- Verified rewards summary isn't lost after browser restart
- Verified able to tip verified pubs when AC is turned off
Wallet funded via KYC'd uphold alone
- Verified wallet status is Verified in brave://rewards-internals
- Verified checkmark is shown in BR panel as well as in Tipping banner for verified pubs
- Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
- Verified checkmark is shown in Monthly contributions and One-time tips for verified pubs
- Verified one-time tips and monthly tips processed successfully
- Verified AC is working fine for verified pubs (added more than 3 pubs in AC table)
- Verified AC is triggered for connected pubs (e.g DDG)
- Verified one-time tips sent for connected pubs isn't displayed in tips panel as expected
- Verified one time tips and recurring tips for a connected publisher is going into pending contribution list after AC
- Verified wallet summary is displayed correctly
- Verified wallet summary and monthly statement are showing the correct stats for One-time tip, monthly tip and AC
- Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
- Verified transactions are listed correctly in Uphold Recent Activity section
- Verified rewards summary isn't lost after browser restart
- Verified able to tip verified pubs when AC is turned off
Wallet balance =(Ad grants+KYC'd uphold)
- Blocked due to [Desktop] user funds do not move to Uphold - follow up to 8428 #11298
Wallet balance =(UGP+KYC'd uphold)
- Verified wallet status is Verified in brave://rewards-internals
- Verified checkmark is shown in AC table, Monthly contribution table and One-time tips panel for verified pubs
- Verified checkmark is shown in Monthly contributions and One-time tips for verified pubs
- Verified one-time tips and monthly tips processed successfully
- Verified AC is working fine for verified pubs (added more than 3 pubs in AC table)
- Verified wallet summary is displayed correctly
- Verified wallet summary is showing the correct stats for One-time tip, monthly tip and AC
- Verified brave://rewards-internals data is shown as expected for Contributions, General info and Promotions
- Verified BAT distributed to verified pubs after AC is shown correctly in brave://rewards-internals page
- Verified BAT distributed for AC from Rewards (UGP) and Uphold is shown correctly
- Verified transactions are listed correctly in Uphold Recent Activity section
- Verified GH, Vimeo, YT, general verified pubs can be added to AC table
- Verified rewards summary isn't lost after browser restart
- Verified able to tip verified pubs when AC is turned off
Wallet balance =(UGP+Deposited BAT)
- Not supported for Android
Wallet balance =(Deposited BAT+KYC'd Uphold wallet )
- Not supported for Android

NejcZdovc added the feature/rewards label May 7, 2020

NejcZdovc assigned emerick Jun 8, 2020

emerick mentioned this issue Jun 22, 2020

Audit Rewards server responses brave/brave-core#5918

Merged

32 tasks

emerick added the QA/Yes label Jun 22, 2020

emerick closed this as completed in brave/brave-core#5918 Jul 23, 2020

emerick added this to the 1.13.x - Nightly milestone Jul 23, 2020

emerick added the release-notes/exclude label Jul 23, 2020

emerick added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Aug 10, 2020

LaurenWags added the QA/Blocked label Aug 17, 2020

LaurenWags removed the QA/Blocked label Aug 17, 2020

GeetaSarvadnya added the QA Pass-Win64 label Aug 21, 2020

This was referenced Aug 21, 2020

Manual test run on OS X for 1.13.x - Release #11375

Closed

Manual test run on Linux for 1.13.x - Release #11377

Closed

LaurenWags added the QA Pass-macOS label Aug 24, 2020

btlechowski added the QA Pass-Linux label Aug 25, 2020

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels Aug 31, 2020

srirambv mentioned this issue Sep 9, 2020

[Android] Issues to be verified from 1.13.x Release #1 #11636

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Audit server responses #9666

Audit server responses #9666

NejcZdovc commented May 7, 2020

emerick commented Jun 18, 2020

LaurenWags commented Aug 17, 2020

GeetaSarvadnya commented Aug 20, 2020 •

edited by btlechowski

Loading

srirambv commented Aug 31, 2020

Audit server responses #9666

Audit server responses #9666

Comments

NejcZdovc commented May 7, 2020

emerick commented Jun 18, 2020

LaurenWags commented Aug 17, 2020

GeetaSarvadnya commented Aug 20, 2020 • edited by btlechowski Loading

srirambv commented Aug 31, 2020

GeetaSarvadnya commented Aug 20, 2020 •

edited by btlechowski

Loading