Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unparsed HTML in Shields section of Settings Page #9690

Closed
say4n opened this issue May 8, 2020 · 10 comments
Closed

Unparsed HTML in Shields section of Settings Page #9690

say4n opened this issue May 8, 2020 · 10 comments
Labels
closed/works-for-me feature/settings l10n OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@say4n
Copy link

say4n commented May 8, 2020

Description

brave://settings/ page shows Look & feel instead of Look & feel for the heading.

Steps to Reproduce

  1. Go to brave://settings/
  2. Scroll down to the last item of Shields.
  3. That's it!

Actual result:

Screenshot 2020-05-08 at 4 54 15 PM

Expected result:

The heading should read "Look & feel"

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.8.90 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS macOS Version 10.15.4 (Build 19E287)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes.
  • Can you reproduce this issue with the beta channel?
    Haven't tried.
  • Can you reproduce this issue with the dev channel?
    Haven't tried.
  • Can you reproduce this issue with the nightly channel?
    Haven't tried.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.
  • Does the issue resolve itself when disabling Brave Rewards?
    No.
  • Is the issue reproducible on the latest version of Chrome?
    No.

Miscellaneous Information:

N/A.

@srirambv
Copy link
Contributor

srirambv commented May 8, 2020

Can you update to 1.8.95 and check if its still happening? I don't see the issue on 1.8.95

@say4n
Copy link
Author

say4n commented May 8, 2020

Ah, I did a brew cask install. Will update and get back to you ASAP.

@say4n
Copy link
Author

say4n commented May 8, 2020

Yes, @srirambv I updated to 1.8.95 (stable channel), and it is still there.

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS macOS Version 10.15.4 (Build 19E287)

Screenshot 2020-05-08 at 5 06 47 PM

@srirambv
Copy link
Contributor

srirambv commented May 8, 2020

Cant reproduce
image

cc: @kjozwiak @LaurenWags

@LaurenWags
Copy link
Member

Reproducible with English (UK), possibly other variants as well. Does not reproduce with English (US).

Brave | 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

English (UK):
Screenshot 2020-05-08 at 7 47 06 AM

English (US):
Screen Shot 2020-05-08 at 7 48 15 AM

@rebron
Copy link
Collaborator

rebron commented May 8, 2020

cc: @petemill While you're still in Settings can you take a look. Looks like a l10n issue with Look and Feel and displays with UK locale.

@say4n
Copy link
Author

say4n commented May 8, 2020

@rebron my issue is with en_IN though (not en_GB), I guess it may be an issue with locales other than en_US?

@LaurenWags
Copy link
Member

@rebron I believe @say4n is correct, I didn't test every non-US English option for language on my laptop so my guess is that this affects multiple languages.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 12, 2020
@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2020

+1 from @chaithanya-hr via brave/brave-ios#2594

@say4n
Copy link
Author

say4n commented Jul 23, 2020

This issue seems to have been resolved. My current version string is as follows:

Brave 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS macOS Version 10.15.6 (Build 19G73)

Edit: Adding a screenshot.
Screenshot 2020-07-23 at 5 09 18 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me feature/settings l10n OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Development

No branches or pull requests

5 participants