Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove Sponsored images/Background images for devices running < Android 6 #9694

Closed
srirambv opened this issue May 8, 2020 · 3 comments · Fixed by brave/brave-core#5969
Assignees

Comments

@srirambv
Copy link
Contributor

srirambv commented May 8, 2020

Description

Remove Sponsored images/Background images for devices running < Android 6

Steps to reproduce

  1. Install Brave on a device running < Android 6
  2. Should not show any SI or Background images

Actual result

Currently shows

Expected result

Should not show

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: Android 6

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Internal discussion here https://bravesoftware.slack.com/archives/C0816QH3R/p1588953717359200
cc: @kjozwiak @anthonypkeane @SergeyZhukovsky

@srirambv srirambv added suggestion QA/Yes OS/Android Fixes related to Android browser functionality labels May 8, 2020
@srirambv srirambv added this to the Android 1.8.x HF 1 Release milestone May 8, 2020
@kjozwiak
Copy link
Member

@SergeyZhukovsky I don't think this is going to get done for the 1.8.x HF1 release as we want to get both #9733 and #9724 out ASAP.

Lets move this into 1.9.x for now 👍 Thoughts? CCing @bsclifton.

@bsclifton
Copy link
Member

Definitely won't make it for the hotfix we're working on for all platforms. But it can be in a following one or the 1.9 release 👍

@LaurenWags
Copy link
Member

LaurenWags commented Jul 20, 2020

Verification passed on LG Nexus 5 (ARM) with Android 5.1 running 1.11.98 using BraveModernx86.apk

  • Confirmed for a clean install of 1.11.98 there are no background or SI on the NTP.
  • Confirmed the previous NTP settings under Settings > Display are not shown
  • Upgrade case 1 - Installed 1.10.99. Ensured background and SI were enabled on NTP. Upgrade to 1.11.98, confirmed there are no NTP images.
  • Upgrade case 2 - Installed 1.10.99. Ensured background were enabled on NTP but SI were toggled off. Upgrade to 1.11.98, confirmed there are no NTP images.
  • Upgrade case 3 - Installed 1.10.99. Ensured background were disabled on NTP. Upgrade to 1.11.98, confirmed there are no NTP images.
  • Note, on clean install, this is what the screen looks like if the top site tiles are not ready:
    Screenshot_2020-07-20-08-23-21

Verification PASSED on Samsun Galaxy J3 version 5.1.1 running BraveModernarm 1.11.98

Clean profile:

  • Verified that 1stNTP page is empty (no top tiles display) when brave in launched with a clean profile
  • Verified that 2nd NTP is displayed with top tiles ( by default 7 top tiles)
  • Verified that New Tab Page settings are not present in Display settings (Settings->Display)
  • Verified that Rate Brave settings is added in Display settings
  • Verified that Background images and Sponsored image are not shown in NTP
  • Verified that default brave images are shown NTP background
  • Verified that user can open more than 25+ tabs load with different websites and restart browser will retain all the opened tabs
  • Verified that user can close all the opened tabs by clicking on tab tray and by selecting close all tabs options
  • Verified that no crash when user change the theme/ or any settings

Upgraded profile: (Upgraded from GPS version to 1.11.98)

  • Verified that New Tab Page settings are not present under display settings in the upgraded profile
  • Verified that Background image and sponsored images are not shown in NTP's in an upgraded profile
  • Verified that Background image and sponsored images are not shown in NTP in 1.11.98 when both BG and SI settings are disabled in GPS and upgraded to 1.11.98
  • Verified that Background image and sponsored images are not shown in NTP in 1.11.98 when SI is disabled in GPS and upgraded to 1.11.98
  • Verified that NTP's are displayed with default brave background images
  • Verified that user can open more than 25+ tabs load with different websites and restart browser will retain all the opened tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants