Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Rewards icon reappears after restarting when SafetyNet fails #9871

Closed
samartnik opened this issue May 21, 2020 · 2 comments · Fixed by brave/brave-core#5612 or brave/brave-core#6493
Closed

[Android] Rewards icon reappears after restarting when SafetyNet fails #9871

samartnik opened this issue May 21, 2020 · 2 comments · Fixed by brave/brave-core#5612 or brave/brave-core#6493
Assignees
@samartnik
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
1.12.x - Release #1

Comments

@samartnik
Copy link
Contributor

Description

Rewards icon reappears after restarting when SafetyNet fails

Steps to reproduce

  1. On device where SafetyNet fails, try to create wallet
  2. Rewards icons disappears
  3. Restart browser, icon appears again

Actual result

Icon appears again after restart

Expected result

Icon doesn't appears again after restart

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.11.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label May 21, 2020
@samartnik samartnik self-assigned this May 21, 2020
@samartnik samartnik mentioned this issue May 21, 2020
Merged
32 tasks
@samartnik samartnik added this to the 1.11.x - Nightly milestone May 21, 2020
@samartnik
Copy link
Contributor Author

Test plan:

  1. Follow STR

@srirambv srirambv mentioned this issue Jul 7, 2020
Closed
10 tasks
This was referenced Jul 8, 2020
Closed
Closed
Closed
@samartnik
Copy link
Contributor Author

Fix was overwritten by cr84 branch and was fixed again in 1.12.x in the context of this issue brave/brave-core#5967

@samartnik samartnik mentioned this issue Aug 25, 2020
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.12.x - Release #1
3 participants
@NejcZdovc @srirambv @samartnik