-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Address bar background color does not change in private mode when dark theme is enabled #9945
Comments
I'm not able to reproduce this on Windows - @georapbox do you have the mouse in the URL bar? If the URL bar is hovered, it will change to that color |
@karenkliu , we are using different address bar bg colors for light/dark theme like captured below. |
Unfortunately I don't have a Windows machine available at the moment to test. The issue appears to be on MacOS though. The address bar background color does not adjust to the purple theme of the private window. Below I attach a screenshot comparing light and dark theme along with how the address bar reacts on mouse away, mouse over and focus states. Hope this proves helpful.. |
@georapbox this is perfect, thanks! So without mouse above, it's black rather than purple. Can see problem clearly now |
@georapbox Thanks for the screenshot! @simonhong In private/Tor mode we use the same colors in light and dark theme. As you can see from the above screenshot, in dark theme the address bar background should not be dark grey - it should be purple, the same as light theme. |
☝️ Changing Chromium colored address bar links to Brave-styled in light/dark should probably be logged as a separate issue. |
Verification passed on
Reproduced issue in 1.11.x
Custom theme - PT window light theme Custom theme - PT window dark theme Verification passed on
Reproduced issue in 1.11.x
Verified passed with
|
Description
When dark theme is enabled, if I open a Private window, the address bar background color remains the same as in normal window. If light theme is enabled, the address bar background color changes to adjust to the purple theme of the Private window.
Steps to Reproduce
Actual result:
The address bar background color is the same with the one of the dark theme, not adjusting to the purple theme of the private window.
Expected result:
The address bar background color should change to adjust to the purple theme of the private window.
Reproduces how often:
Always
Brave version (brave://version info)
Brave: 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision: 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS: macOS Version 10.15.1
Version/Channel Information:
Yes
Yes
Yes
Yes
Other Additional Information:
Not related to Brave Shields
Not related to Brave Rewqrds
No
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: