From 3fc5428c9c9f120ab0c082b3bb44f2962aeaef3e Mon Sep 17 00:00:00 2001 From: Max Karolinskiy Date: Thu, 27 Apr 2023 23:29:18 -0400 Subject: [PATCH] Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS. The test fails because in Chromium Private/Incognito profiles now ignore the "Ask for download location" setting and always prompt for the location. We will fix that in https://github.com/brave/brave-browser/issues/29823, but until then let's disable this test on MacOS. --- browser/ui/window_closing_confirm_browsertest.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/browser/ui/window_closing_confirm_browsertest.cc b/browser/ui/window_closing_confirm_browsertest.cc index c6faccc9b924..fe07d683dab5 100644 --- a/browser/ui/window_closing_confirm_browsertest.cc +++ b/browser/ui/window_closing_confirm_browsertest.cc @@ -265,7 +265,15 @@ IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest, ui_test_utils::WaitForBrowserToClose(brave_browser); } -IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest, TestWithDownload) { +// Temporarily disable the test on MacOS until +// https://github.com/brave/brave-browser/issues/29823 is fixed. +#if BUILDFLAG(IS_MAC) +#define MAYBE_TestWithDownload DISABLED_TestWithDownload +#else +#define MAYBE_TestWithDownload TestWithDownload +#endif +IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest, + MAYBE_TestWithDownload) { // On macOS, download in-progress warning is not shown for normal profile window // closing as it can still continue after window is closed. // However, private profile window works like normal window of other platforms.