From 785af96ebd19cff4a9995f9784da67e93e29ad2f Mon Sep 17 00:00:00 2001 From: mkarolin <41635752+mkarolin@users.noreply.github.com> Date: Tue, 9 Jun 2020 17:53:01 -0400 Subject: [PATCH] Merge pull request #5777 from brave/maxk-issue-10160 Fixes crash in brave://settings/content/all. --- .../chrome/browser/ui/webui/site_settings_helper.cc | 13 ++++--------- ...e-browser-ui-webui-site_settings_helper.cc.patch | 12 ++++++++++++ 2 files changed, 16 insertions(+), 9 deletions(-) create mode 100644 patches/chrome-browser-ui-webui-site_settings_helper.cc.patch diff --git a/chromium_src/chrome/browser/ui/webui/site_settings_helper.cc b/chromium_src/chrome/browser/ui/webui/site_settings_helper.cc index be7cc6718696..946ad81fbf54 100644 --- a/chromium_src/chrome/browser/ui/webui/site_settings_helper.cc +++ b/chromium_src/chrome/browser/ui/webui/site_settings_helper.cc @@ -4,14 +4,15 @@ * You can obtain one at http://mozilla.org/MPL/2.0/. */ #define HasRegisteredGroupName HasRegisteredGroupName_ChromiumImpl -#define ContentSettingsTypeFromGroupName \ - ContentSettingsTypeFromGroupName_ChromiumImpl #define ContentSettingsTypeToGroupName \ ContentSettingsTypeToGroupName_ChromiumImpl +#define BRAVE_SITE_SETTINGS_HELPER_CONTENT_SETTINGS_TYPE_FROM_GROUP_NAME \ + if (name == "autoplay") \ + return ContentSettingsType::AUTOPLAY; #include "../../../../../../chrome/browser/ui/webui/site_settings_helper.cc" +#undef BRAVE_SITE_SETTINGS_HELPER_CONTENT_SETTINGS_TYPE_FROM_GROUP_NAME #undef ContentSettingsTypeToGroupName -#undef ContentSettingsTypeFromGroupName #undef HasRegisteredGroupName namespace site_settings { @@ -22,12 +23,6 @@ bool HasRegisteredGroupName(ContentSettingsType type) { return HasRegisteredGroupName_ChromiumImpl(type); } -ContentSettingsType ContentSettingsTypeFromGroupName(const std::string& name) { - if (name == "autoplay") - return ContentSettingsType::AUTOPLAY; - return ContentSettingsTypeFromGroupName_ChromiumImpl(name); -} - std::string ContentSettingsTypeToGroupName(ContentSettingsType type) { if (type == ContentSettingsType::AUTOPLAY) return "autoplay"; diff --git a/patches/chrome-browser-ui-webui-site_settings_helper.cc.patch b/patches/chrome-browser-ui-webui-site_settings_helper.cc.patch new file mode 100644 index 000000000000..98b44c8ab26d --- /dev/null +++ b/patches/chrome-browser-ui-webui-site_settings_helper.cc.patch @@ -0,0 +1,12 @@ +diff --git a/chrome/browser/ui/webui/site_settings_helper.cc b/chrome/browser/ui/webui/site_settings_helper.cc +index 9de4ee74b87ccd0502f2f77438cfe5fecbb23fec..860835e9b3057276fc99a8e4048598d6e2e2fd49 100644 +--- a/chrome/browser/ui/webui/site_settings_helper.cc ++++ b/chrome/browser/ui/webui/site_settings_helper.cc +@@ -371,6 +371,7 @@ bool HasRegisteredGroupName(ContentSettingsType type) { + } + + ContentSettingsType ContentSettingsTypeFromGroupName(const std::string& name) { ++ BRAVE_SITE_SETTINGS_HELPER_CONTENT_SETTINGS_TYPE_FROM_GROUP_NAME + for (size_t i = 0; i < base::size(kContentSettingsTypeGroupNames); ++i) { + if (name == kContentSettingsTypeGroupNames[i].name) + return kContentSettingsTypeGroupNames[i].type;