From e509b8065d68fff6b35cd40373f0784b4585ae12 Mon Sep 17 00:00:00 2001 From: mkarolin Date: Wed, 1 Sep 2021 15:01:57 -0400 Subject: [PATCH] [MacOS][Signing] Revert overwriting Alerts helper app id. Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: https://github.com/brave/brave-core/pull/8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731 --- script/signing_helper.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/script/signing_helper.py b/script/signing_helper.py index 805b40348e10..292db853ba9a 100644 --- a/script/signing_helper.py +++ b/script/signing_helper.py @@ -124,11 +124,6 @@ def AddBravePartsForSigning(parts, config): parts['helper-app'].options = (CodeSignOptions.RESTRICT + CodeSignOptions.KILL + CodeSignOptions.HARDENED_RUNTIME) - # Alerts helper is not being distributed with Chrome yet and, because it - # uses the same identifier as the current Alerts service, the signing fails. - # For now we can set a different identifier and then remove this change once - # the helper starts being bundled into the distribution. - parts['helper-alerts'].identifier = '{}.helper.alerts'.format(config.base_bundle_id) return parts