From b1dc066af5eca0a8b738c25098a90566ad4a440a Mon Sep 17 00:00:00 2001 From: Serg Date: Tue, 24 Jan 2023 16:40:31 -0500 Subject: [PATCH] Fixes a crash on a DApp websites when we execute a wallet detection event on Android --- .../brave_wallet_provider_delegate_impl_helper_android.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/browser/brave_wallet/brave_wallet_provider_delegate_impl_helper_android.cc b/browser/brave_wallet/brave_wallet_provider_delegate_impl_helper_android.cc index b253b2328599..2ede7045461d 100644 --- a/browser/brave_wallet/brave_wallet_provider_delegate_impl_helper_android.cc +++ b/browser/brave_wallet/brave_wallet_provider_delegate_impl_helper_android.cc @@ -27,14 +27,15 @@ void ShowWalletOnboarding(content::WebContents*) { Java_BraveWalletProviderDelegateImplHelper_showWalletOnboarding(env); } -void ShowAccountCreation(content::WebContents* web_contents, - const std::string& keyring_id) { +void ShowAccountCreation(content::WebContents*, const std::string& keyring_id) { JNIEnv* env = base::android::AttachCurrentThread(); Java_BraveWalletProviderDelegateImplHelper_ShowAccountCreation( env, base::android::ConvertUTF8ToJavaString(env, keyring_id)); } void WalletInteractionDetected(content::WebContents* web_contents) { + if (!web_contents) + return; Java_BraveWalletProviderDelegateImplHelper_walletInteractionDetected( base::android::AttachCurrentThread(), web_contents->GetJavaWebContents()); }