Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Do not force portrait mode when device is in landscape #1491

Closed
srirambv opened this issue Sep 5, 2019 · 1 comment
Closed

Do not force portrait mode when device is in landscape #1491

srirambv opened this issue Sep 5, 2019 · 1 comment

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2019

Description:

Do not force portrait mode when the device is in landscape

Steps to Reproduce

  1. Keep device in landscape mode
  2. Open settings page
  3. Switches to portait mode
  4. Close settings, remains on portrait mode unless the device is rotated to portrait and back to landscape

Actual result:
Do not force portrait mode when device is in landscape

Expected result:
Should auto detect device orientation and switch back to landscape when settings page is closed

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12

Device details:
iPhone XR (iOS13

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Follow up to #867

@jonathansampson
Copy link
Contributor

Similarly, the browser will switch to portrait mode when you open the tipping panel while in landscape. This was recently reported by a user on Twitter:

tipping-panel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants