Single colour favicons are not always visible over generated background color

[GeetaSarvadnya]

Description:

If a favicon has a single colour, the generated background colour (based on colour in the favicon) makes the favicon itself not visible. This is very obvious on sites such as brianbondy.com

Steps to Reproduce

1. Clean profile 1.14
2. Enable rewards and fund the wallet
3. Add few verified pubs to a-c table
4. Send a one-time tip to a verified pubs
5. Favicon isn't displayed for few verified pubs in a-c table, BR panel and tip sent thank you banner

Actual result:
Favicon isn't displayed for few verified pubs in a-c table, BR panel and tip sent thank you banner

Expected result:
The favicon should be displayed for verified pubs in a-c table, BR panel and tip sent thank you banner

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always
Brave Version:
1.14

Device details:
iPhone8

Website problems only:

• did you check with Brave Shields down? NA
• did you check in Safari/Firefox (WkWebView-based browsers)? NA
  
  
  
  

Additional Information

Reproduced in play store version 1.13 also

cc: @brave/legacy_qa @jhreis

[kylehickinson]

This ticket doesn't actually have anything to do with Rewards related favicons, it affects all favicons in the app. The favicon is there, but we generated a background color for favicons based on dominate color, and in this case, brianbondy.com's favicon is all 1 color, which will affect its visibility:

[srirambv]

Verification passed on iPhone XR with iOS 13.5 running 1.18(20.06.16.08)

• Verified publishers favicon is shown correctly in BR panel
• Verified publishers favicon is shown correctly in AC list
• Vierified publishers favicon is shown correctly in Tabs overview

---

Verification passed on iPhone 7+ with iOS 13.4.5 running 1.18(20.06.16.08)

• Verified publishers favicon is shown correctly in BR panel
• Verified publishers favicon is shown correctly in AC list
• Vierified publishers favicon is shown correctly in Tabs overview

---

Verification passed on iPad Pro with iOS 12.4.5 running 1.18(20.06.16.08)

• Verified publishers favicon is shown correctly in BR panel
• Verified publishers favicon is shown correctly in AC list
• Vierified publishers favicon is shown correctly in Tabs overview

---