Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Support "Open in Place" for the Downloads folder #225

Closed
tmancey opened this issue Sep 4, 2018 · 7 comments
Closed

Support "Open in Place" for the Downloads folder #225

tmancey opened this issue Sep 4, 2018 · 7 comments
Labels
blocked: needs info Needs further information before work can commence enhancement QA/Yes release-notes/include

Comments

@tmancey
Copy link
Collaborator

tmancey commented Sep 4, 2018

Support "Open in Place" for the Downloads folder so that users can open downloaded content directly on their device

@jhreis
Copy link
Contributor

jhreis commented Mar 27, 2019

@tmancey Can you please provide a bit more info about this ticket, and if it is a duplicate of #206 ?

@jhreis jhreis added the blocked: needs info Needs further information before work can commence label Mar 27, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Mar 28, 2019

@jhreis This is not the same, for "open in place" see https://developer.apple.com/document-based-apps/ for when users download PDFs etc.

@kylehickinson
Copy link
Collaborator

kylehickinson commented Nov 16, 2019

Is this ticket still valid? Is #1467 a duplicate of this?

@tmancey
Copy link
Collaborator Author

tmancey commented Nov 16, 2019

@kylehickinson Open in place would allow users to open files directly, i.e. preview from the browser

@kylehickinson
Copy link
Collaborator

Is there a reason why we'd want to do this? I think the quick look preview would be good enough, and let the user open the document in the proper app outside of Brave.

@kylehickinson
Copy link
Collaborator

Turns out the Open In (from UIDocumentInteractionController) shows pretty much the same thing as the activity controller now… without the preview. Will probably stick with the QuickLook previewer instead

@kylehickinson
Copy link
Collaborator

Closing for now as we merged QuickLook previewing and closed #1467

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: needs info Needs further information before work can commence enhancement QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

3 participants