Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Discrepancy in the titles of multiple settings screens. #7770

Closed
hffvld opened this issue Jul 21, 2023 · 2 comments · Fixed by #8139
Closed

Discrepancy in the titles of multiple settings screens. #7770

hffvld opened this issue Jul 21, 2023 · 2 comments · Fixed by #8139
Assignees
@soner-yuksel
Labels
bug Epic: Settings OS/iOS QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.60

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jul 21, 2023 •
edited
Loading

Description:

Discrepancy in the titles of multiple settings screens.

Steps to Reproduce

  1. Launch Brave > Three-dot menu > Settings
  2. Open, for example, Brave Rewards or New Tab Page > Observe that title on that screen is the same Brave Rewards or New Tab Page
  3. Now go back to Settings and open, for example, Appearance or Close Tabs > Observe that there is no title on that screen
  4. Go back to Settings and open, for example, Search Engines or Media > Highest Quality Playback > Observe that title is there, but it has a different name, like Search for the first example and Quality Settings for the second.

Actual result:

  • Some screens in the settings have the same title name as on the main Settings screen, for example, Brave Rewards > Brave Rewards or New Tab Page > New Tab Page.
  • Some screens in the settings have different title names, for example, Search Engines > Search or Highest Quality Playback > Quality Settings.
  • Some screens don't have a title at all, for example, Appearance and Close Tabs.
  • This is just an example of this issue, there are more settings like this.
Brave Rewards setting Appearance setting
1 2
Brave Rewards screen Appearance screen
1 2
Search Engines setting Highest Quality Playback setting
3 4
Search Engines screen Highest Quality Playback screen
3 4

Expected result:

There should be consistency in the settings. All screens must have the same title, shorten version of the title or don't have a title at all.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.56 (23.7.19.18)
BraveCore: 1.56.6 (115.0.5790.90)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

Device/OS: iPhone 14 [iOS 16.5.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@soner-yuksel soner-yuksel self-assigned this Sep 22, 2023
@soner-yuksel soner-yuksel added this to the 1.59 milestone Sep 22, 2023
@soner-yuksel soner-yuksel mentioned this issue Sep 22, 2023
Merged
24 tasks
@anthonypkeane
Copy link

@vlad-hoff once the localisation is done can you please check all these titles in a few languages to see if they fit okay? Thanks

@hffvld
Copy link
Collaborator Author

hffvld commented Oct 7, 2023 •
edited
Loading

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.1]
Brave build: 1.59 (23.10.5.15)
BraveCore: 1.59.111 (118.0.5993.21)

STEPS:

  1. Launch Brave > Three-dot menu > Settings
  2. Followed Fix # 7770: Discrepancy in the titles of multiple settings screens #8139 (comment) to compare the strings

ACTUAL RESULTS:

  • Verified that all titles match each other on the Settings screen and particular screen.
English
Content Filtering Content Filtering Privacy Hub Privacy Hub
1 2 3 4
Search Engines Search Engines Standard Tab Standard Tab
1 2 3 4
Private Tab Private Tab Add Custom Search Engine Add Custom Search Engine
1 2 3 4
Highest Quality Playback Highest Quality Playback Appearance Appearance
1 2 3 4
Page Zoom Page Zoom Tabs Bar Tabs Bar
1 2 3 4
Close Tabs Close Tabs Privacy Policy Privacy Policy
1 2 3 4
Terms of Use Terms of Use
1 2
Russian
Content Filtering Content Filtering Privacy Hub Privacy Hub
1 2 3 4
Search Engines Search Engines Standard Tab Standard Tab
1 2 3 4
Private Tab Private Tab Add Custom Search Engine Add Custom Search Engine
1 2 3 4
Highest Quality Playback Highest Quality Playback Appearance Appearance
1 2 3 4
Page Zoom Page Zoom Tabs Bar Tabs Bar
1 2 3 4
Close Tabs Close Tabs Privacy Policy Privacy Policy
1 2 3 4
Terms of Use Terms of Use
1 2
German
Content Filtering Content Filtering Privacy Hub Privacy Hub
1 2 3 4
Search Engines Search Engines Standard Tab Standard Tab
1 2 3 4
Private Tab Private Tab Add Custom Search Engine Add Custom Search Engine
1 2 3 4
Highest Quality Playback Highest Quality Playback Appearance Appearance
1 2 3 4
Page Zoom Page Zoom Tabs Bar Tabs Bar
1 2 3 4
Close Tabs Close Tabs Privacy Policy Privacy Policy
1 2 3 4
Terms of Use Terms of Use
1 2
Spanish
Content Filtering Content Filtering Privacy Hub Privacy Hub
1 2 3 4
Search Engines Search Engines Standard Tab Standard Tab
1 2 3 4
Private Tab Private Tab Add Custom Search Engine Add Custom Search Engine
1 2 3 4
Highest Quality Playback Highest Quality Playback Appearance Appearance
1 2 3 4
Page Zoom Page Zoom Tabs Bar Tabs Bar
1 2 3 4
Close Tabs Close Tabs Privacy Policy Privacy Policy
1 2 3 4
Terms of Use Terms of Use
1 2
Japanise
Content Filtering Content Filtering Privacy Hub Privacy Hub
1 2 3 4
Search Engines Search Engines Standard Tab Standard Tab
1 2 3 4
Private Tab Private Tab Add Custom Search Engine Add Custom Search Engine
1 2 3 4
Highest Quality Playback Highest Quality Playback Appearance Appearance
1 2 3 4
Page Zoom Page Zoom Tabs Bar Tabs Bar
1 2 3 4
Close Tabs Close Tabs Privacy Policy Privacy Policy
1 2 3 4
Terms of Use Terms of Use
1 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
bug Epic: Settings OS/iOS QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.60
Development

Successfully merging a pull request may close this issue.

Fix # 7770: Discrepancy in the titles of multiple settings screens brave/brave-ios
4 participants
@soner-yuksel @anthonypkeane @Uni-verse @hffvld