Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix issue where content blockers are sometimes removed and recompiled during launch #8219

Closed
cuba opened this issue Oct 11, 2023 · 2 comments · Fixed by #8222
Closed

Fix issue where content blockers are sometimes removed and recompiled during launch #8219

cuba opened this issue Oct 11, 2023 · 2 comments · Fixed by #8222

Comments

@cuba
Copy link
Contributor

cuba commented Oct 11, 2023

Description:

Sometimes the content blockers are removed and recompiled unnecessarily during launch.
This cannot be tested.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@kylehickinson
Copy link
Collaborator

At the very least the adblocking aspect should be sanity tested after this change

@iccub iccub added this to the 1.58 milestone Oct 11, 2023
@iccub iccub added the bug label Oct 11, 2023
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.0.3 using version 1.58 (23.10.17.8)

Sanity tested the following areas

Content ads / Video ads

  • Ensured that content ads are blocked on youtube.com, x.com and other sites with default settings on fresh install.
  • Ensured that preroll ads are not shown for youtube videos when Shields are up. Bringing down Shields will show the ads.
  • Ensured adblocking is working in standard and aggressive modes
Example Example
IMG_5187 IMG_5188

Cosmetic Filtering

Example Example Example Example
IMG_5174 IMG_5175 IMG_5189 IMG_5184
IMG_5183 IMG_5175 IMG_5182 IMG_5185

Cookie Consent Notice

Example Example
IMG_5173 IMG_5181

Tracking Content

0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants