From 04f13130f121c274d48cff39c1541c2c08a7c65e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EF=BD=81=EF=BD=99=EF=BD=95=EF=BD=8D=EF=BD=89=C2=A0=20?= =?UTF-8?q?=EF=BD=99=EF=BD=95?= Date: Tue, 13 Jun 2017 22:54:07 +0000 Subject: [PATCH] Don't sort sites when adding or removing Because both operations retain sites iteration order. Fix #9427 --- app/browser/reducers/sitesReducer.js | 2 -- app/sync.js | 1 - 2 files changed, 3 deletions(-) diff --git a/app/browser/reducers/sitesReducer.js b/app/browser/reducers/sitesReducer.js index 85cc830b5d8..a2ea7d0ecff 100644 --- a/app/browser/reducers/sitesReducer.js +++ b/app/browser/reducers/sitesReducer.js @@ -75,12 +75,10 @@ const sitesReducer = (state, action, immutableAction) => { state = syncUtil.updateSiteCache(state, action.destinationDetail || action.siteDetail) } } - state = state.set('sites', state.get('sites').sort(siteUtil.siteSort)) state = updateActiveTabBookmarked(state) break case appConstants.APP_REMOVE_SITE: state = siteUtil.removeSite(state, action.siteDetail, action.tag, true) - state = state.set('sites', state.get('sites').sort(siteUtil.siteSort)) if (syncEnabled()) { state = syncUtil.updateSiteCache(state, action.siteDetail) } diff --git a/app/sync.js b/app/sync.js index c3a597cb494..aa0b4f89536 100644 --- a/app/sync.js +++ b/app/sync.js @@ -266,7 +266,6 @@ module.exports.onSyncReady = (isFirstRun, e) => { // Sync bookmarks that have not been synced yet. siteUtil.getBookmarks(sites).filter(site => shouldSyncBookmark(site)) - .sortBy(site => site.get('order')) .forEach(syncBookmark) // Sync site settings that have not been synced yet