From fce5ebf048a13598b94e5c436f4daef7b6cdb9f6 Mon Sep 17 00:00:00 2001 From: Cezar Augusto Date: Fri, 11 Aug 2017 19:22:41 -0300 Subject: [PATCH] replace classList with dataset for bookmarksOverflowIndicator Fix #10443 Auditors: @luixxiul, @bsclifton --- .../components/common/contextMenu/contextMenuItem.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/renderer/components/common/contextMenu/contextMenuItem.js b/app/renderer/components/common/contextMenu/contextMenuItem.js index 5c7c3d9637c..f1fe573eea2 100644 --- a/app/renderer/components/common/contextMenu/contextMenuItem.js +++ b/app/renderer/components/common/contextMenu/contextMenuItem.js @@ -14,6 +14,7 @@ const windowActions = require('../../../../../js/actions/windowActions') // Utils const cx = require('../../../../../js/lib/classSet') const {formatAccelerator} = require('../../../../common/lib/formatUtil') +const {elementHasDataset} = require('../../../../../js/lib/eventUtil') class ContextMenuItem extends ImmutableComponent { componentDidMount () { @@ -94,11 +95,11 @@ class ContextMenuItem extends ImmutableComponent { if (this.hasSubmenu) { let node = e.target - while (node && node.classList && !node.classList.contains('contextMenuItem')) { + while (node && elementHasDataset(node, 'contextMenuItem')) { node = node.parentNode } let parentNode = node.parentNode - while (parentNode && parentNode.classList && !parentNode.classList.contains('contextMenu')) { + while (parentNode && !elementHasDataset(parentNode, 'contextMenu')) { parentNode = parentNode.parentNode } const parentBoundingRect = parentNode.getBoundingClientRect()