Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sites shows up with 0 views in payments #10036

Closed
srirambv opened this issue Jul 18, 2017 · 3 comments
Closed

Sites shows up with 0 views in payments #10036

srirambv opened this issue Jul 18, 2017 · 3 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jul 18, 2017

Test plan

  1. Clean install 0.19
  2. Enable payments (keep defaults)
  3. Visit sites (both on exclude list and not on exclude list),
  4. Make sure that the visits are counted properly

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Sites shows up with 0 views in payments

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):

Brave 0.17.17
rev dbc3c4d
Muon 4.1.8
  • Steps to reproduce:

    1. Clean install 0.17.17
    2. Enable payments (keep defaults)
    3. Visit sites(both on exclude list and not on exclude list), show up as 0 views instantly after opening the page
  • Actual result:
    Sites shows up with 0 views in payments

  • Expected result:
    Should show proper view count for added sites

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes (Sites visited before payment enabling is shown as 0 views #9980)

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    Sites visited before payment enabling is shown as 0 views #9980

@luixxiul
Copy link
Contributor

@NejcZdovc will this issue be fixed with #11037?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 23, 2017
@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Sep 23, 2017
@NejcZdovc
Copy link
Contributor

@luixxiul hope so 😃

@NejcZdovc
Copy link
Contributor

this was broken with #9952

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.