Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Suggestion: Add option to disable notifications #10540

Closed
Jacalz opened this issue Aug 16, 2017 · 4 comments
Closed

Suggestion: Add option to disable notifications #10540

Jacalz opened this issue Aug 16, 2017 · 4 comments
Labels
duplicate Issue has already been reported feature/notificationbar needs-info Another team member needs information from the PR/issue opener. suggestion

Comments

@Jacalz
Copy link
Contributor

Jacalz commented Aug 16, 2017

  • Did you search for similar issues before submitting this one?

  • Describe the issue you encountered:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA):

  • Steps to reproduce:
    1.
    2.
    3.

  • Actual result:

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@Jacalz
Copy link
Contributor Author

Jacalz commented Aug 16, 2017

@luixxiul
Copy link
Contributor

is it ok to close this in favor of #2215?

@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. feature/notificationbar labels Sep 13, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@ryanml
Copy link
Contributor

ryanml commented Feb 27, 2018

I've laid out the initial work for such a feature on this branch.

Where there will need to be some larger discussion:

  1. Naming, Help Text, and Placement within settings for this toggle.
  2. Exactly what type of notifications should be covered in this settings' scope. With the work on this branch, all notifications would be disabled should they be switched off. This may be good, but for things like browser restart notifications we probably want to show those regardless. Per Issue Preference to always block website notifications and other requests #2215 it sounds like we may want this to only cover site-specific notifications.

cc: @Jacalz @luixxiul @bridiver @bsclifton

See also:

@bsclifton bsclifton added the duplicate Issue has already been reported label Aug 20, 2018
@bsclifton
Copy link
Member

Closing as a duplicate of #12467

@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue has already been reported feature/notificationbar needs-info Another team member needs information from the PR/issue opener. suggestion
Projects
None yet
Development

No branches or pull requests

5 participants