Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinning a tab leads to previous tab to be wrapped as pinned too #11220

Closed
cezaraugusto opened this issue Sep 30, 2017 · 4 comments
Closed

pinning a tab leads to previous tab to be wrapped as pinned too #11220

cezaraugusto opened this issue Sep 30, 2017 · 4 comments
Assignees
@cezaraugusto
Labels
bug feature/pinned-tabs needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

SHA c5a903c

STR:

  1. Open 3 tabs
  2. Pin far-right tab
  3. tab next to pinned one becomes smaller, inspect shows them all wrapped around element w/ .pinnedTabs class. Next tab is not pinned but still child of wrapper element

This is failing several pinned tabs tests

setting as needs-investigation to check if previous versions were affected too
@cezaraugusto cezaraugusto added bug feature/pinned-tabs needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Sep 30, 2017
@cezaraugusto cezaraugusto added this to the 0.21.x (Nightly Channel) milestone Sep 30, 2017
@cezaraugusto cezaraugusto self-assigned this Sep 30, 2017
@luixxiul
Copy link
Contributor

@cezaraugusto do you think this issue has the same root cause as #11205?

@cezaraugusto
Copy link
Contributor Author

correct they're related

@cezaraugusto cezaraugusto mentioned this issue Oct 1, 2017
Merged
8 tasks
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Oct 31, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@cezaraugusto
Copy link
Contributor Author

not happening w/ sha 5af92b4 (current 0.20.x latest) so I'm closing for now.

@luixxiul luixxiul modified the milestones: Prioritized Backlog, 0.20.x (Beta Channel) Nov 7, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Nov 7, 2017

Added to 0.20.x for QA 😄

This was referenced Dec 20, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/pinned-tabs needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @srirambv @LaurenWags