Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Find results stay highlighted even after you hit escape #13931

Closed
bsclifton opened this issue Apr 24, 2018 · 5 comments
Closed

Find results stay highlighted even after you hit escape #13931

bsclifton opened this issue Apr 24, 2018 · 5 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Apr 24, 2018

Description

When using cmd+f (or ctrl+f) to find words on a page, the results stay highlighted even after you press escape to dismiss.

Test plan / Steps to Reproduce

  1. Go to about:brave
  2. Push Cmd + F / Ctrl + F to bring up find bar
  3. Type "Brave" and hit enter
  4. Push escape to dismiss the find

Actual result:

selectingissue

Expected result:
results should not be highlighted

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.22.109
V8: 6.5.254.41
rev: 5e4846e
Muon: 6.0.3
OS Release: 17.5.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 65.0.3325.181

Reproducible on current live release:
no

Additional Information

@bsclifton bsclifton added this to the 0.22.x Release 3 (Beta channel) milestone Apr 24, 2018
@petemill
Copy link
Member

petemill commented May 1, 2018

Should be fixed with upcoming 0.22.701

@petemill petemill added the 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch label May 1, 2018
@petemill petemill self-assigned this May 1, 2018
@bsclifton
Copy link
Member Author

Confirmed this is fixed! 🎉

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented May 3, 2018

@bsclifton : Is this the expected behavior? seeing same on Production as well, last highlighted search item is selected when search bar is closed.
13931

@kjozwiak
Copy link
Member

kjozwiak commented May 3, 2018

@GeetaSarvadnya I talked to @bsclifton and that's expected. I also added a GIF of the original issue in the original comment.

@kjozwiak
Copy link
Member

kjozwiak commented May 3, 2018

Verified on Mint 18.3 x64 using the following build:

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified with macOS 10.12.6 using

  • 0.22.703 903b8d0
  • muon 6.0.8
  • libchromiumcontent 66.0.3359.139

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants