Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tor version missing from about:brave (until you launch a Tor tab) #14731

Closed
LaurenWags opened this issue Jul 13, 2018 · 3 comments
Closed

Tor version missing from about:brave (until you launch a Tor tab) #14731

LaurenWags opened this issue Jul 13, 2018 · 3 comments
Labels
0.23.x issue first seen in 0.23.x bug feature/tor wontfix

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jul 13, 2018

Description

In 0.23.19 when Tor Private tabs were introduced, the Tor version was listed in about:brave. This stopped displaying in 0.23.31 when lazy-loading was introduced. Once you open a private tab with Tor, it will show as expected

Steps to Reproduce

  1. Launch 0.23.19
  2. Navigate to about:brave
  3. See Tor version listed.
  4. Close 0.23.19
  5. Launch 0.23.31
  6. Navigate to about:brave

Actual result:
Tor version is not listed:
screen shot 2018-07-13 at 10 51 19 am

screen shot 2018-07-13 at 10 51 09 am

Expected result:
Tor version should be listed
screen shot 2018-07-13 at 10 47 54 am

Reproduces how often:
Easily

Brave Version

about:brave info:
0.23.35, 0.23.31

Reproducible on current live release:
yes

Additional Information

@LaurenWags LaurenWags added bug 0.23.x issue first seen in 0.23.x labels Jul 13, 2018
@bsclifton bsclifton self-assigned this Jul 13, 2018
@bsclifton bsclifton changed the title Tor version missing from about:brave Tor version missing from about:brave (until you launch a Tor tab) Jul 13, 2018
@bsclifton bsclifton modified the milestones: 0.23.x Release 3 (BETA Channel), Backlog (Prioritized), Triage Backlog Jul 13, 2018
@bsclifton bsclifton removed their assignment Jul 13, 2018
@riastradh-brave
Copy link
Contributor

We get the tor version by talking to the tor daemon. If there's no tor daemon yet because it's lazy-loaded, we don't know its version yet. Is this a problem? Do we need to have the tor version sooner?

@bsclifton
Copy link
Member

@riastradh-brave I think it's OK to not have the Tor version immediately (I kicked it out of this release). Maybe this issue can track making it more elegant. ex: show (not loaded yet) for when the daemon hasn't been loaded

@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 9, 2018
@bsclifton
Copy link
Member

Definitely something we won't fix- but something good to keep in mind when Tor is implemented in brave-core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.23.x issue first seen in 0.23.x bug feature/tor wontfix
Projects
None yet
Development

No branches or pull requests

3 participants