Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Download Delete button click is causing the browser hang #14805

Closed
GeetaSarvadnya opened this issue Jul 23, 2018 · 6 comments
Closed

Download Delete button click is causing the browser hang #14805

GeetaSarvadnya opened this issue Jul 23, 2018 · 6 comments

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jul 23, 2018

Description

When user download two or more than 2 .exe files simultaneously, upon click on cancel and delete download is causing the browser hang

Steps to Reproduce

  1. Open Brave with clean profile
  2. Open a New Private tab with Tor or any Normal tab
  3. If its tor tab wait until tor gets connected successfully
  4. Enter the Url "https://github.com/brave/browser-laptop/releases" in the tor tab
  5. Click on any .exe file and click on save button in the Save as dialog
  6. Repeat the step 5 again and observer that two exe files are getting downloaded
  7. When the download is in progress, click on Cancel icon and cancel the download for 1st and 2nd .exe files (step 5 and step 6 download file)
  8. Click on 'Delete Download' ->OK button

Actual result:
Browser is getting hanged after clicking the OK button
download delete button click causing browser hang

Expected result:
The browser should not get hang

Reproduces how often:
100%

Brave Version

0.23.70
about:brave info:

Brave: 0.23.70
V8: 6.8.275.23
rev: e63c780
Muon: 8.0.1
OS Release: 10.0.17134
Update Channel: Beta
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 68.0.3440.68

Reproducible on current live release:
Yes

Additional Information

@GeetaSarvadnya
Copy link
Collaborator Author

GeetaSarvadnya commented Jul 24, 2018

@bsclifton @kjozwiak @alexwykoff Tested the defect on Live Release 0.23.39 found issue is reproducible on Live version as well.

@btlechowski
Copy link
Contributor

btlechowski commented Jul 26, 2018

Not reproducible on Ubuntu 17.10. Brave v0.23.72
Reproduced on Ubuntu 17.10. Brave v0.23.72.

@kjozwiak
Copy link
Member

Removing the release/blocking as this isn't a new regression and is currently present in 0.23.39 which is the release that's currently live.

@jumde
Copy link
Contributor

jumde commented Jul 31, 2018

Not able to repro with: brave/muon@4504af1

out

@bsclifton
Copy link
Member

Should be fixed with our next build... if not, let's push back to Release 5

@LaurenWags
Copy link
Member

LaurenWags commented Aug 2, 2018

Verified with macOS 10.12.6 using

  • 0.23.74 b508fa7
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84

Verified on Windows using

  • 0.23.74 0125b5f
  • Muon 8.0.6
  • libchromiumcontent 68.0.3440.84
  • Verified downloading multiple files and cancel and delete, browser didn't hang
  • Verified by retrying cancelled download and cancel again, browser didn't hang while deleting the file on second download retry

Verified on Ubuntu 17.10 x64

  • 0.23.77 0125b5f
  • Muon 8.0.6
  • libchromiumcontent 68.0.3440.84

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants