Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New window / popups don't close through javascript #14812

Closed
hugobuddel opened this issue Jul 24, 2018 · 3 comments
Closed

New window / popups don't close through javascript #14812

hugobuddel opened this issue Jul 24, 2018 · 3 comments
Labels
duplicate Issue has already been reported

Comments

@hugobuddel
Copy link
Contributor

Can't find a similar issue

Description

Some sites can open popups that should be closed by pressing an in-site button. E.g. login popups that close themselves when you press the login button. Or a hangouts conversation. Those popups do not close in Brave.

I recall there is something in javascript that allows sites to close popups (or other pages) that they have opened themselves.

Steps to Reproduce

  1. Login on gmail.com, select/start a hangouts conversation (opens in bottom right of gmail page).
  2. Click the 'pop-out' arrow on the top-right of the hangouts conversation. This opens a new window with just the chat. (In Brave this will be a new window with a single open tab; in Chromium it will be a single-page-window without tabs.)
  3. Click the 'pop-in' arrow on the newly opened conversation window. This will put the conversation back in the main gmail window, but not close the pop-up. The tab sort-of 'closes', as in, is removed from the tab-bar. But the actual page is still shown in the popup, but cannot be interacted with.

Actual result:
The popup stays open.

Sorry, no screenshot because it would require quite a bit of censoring since the only example I have are from gmail or from login sites.

Expected result:
The popup closes.

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.23.39
V8: 6.7.288.46
rev: a38be75
Muon: 7.1.6
OS Release: 10.0.17134
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.103

Reproducible on current live release:
Don't know

Additional Information

Might be fixed when using chrome?

Perhaps it is necessary to enable popups for those sites first.

@bsclifton
Copy link
Member

related: #9622, #11050

@bsclifton bsclifton added this to the Triage Backlog milestone Jul 25, 2018
@hugobuddel
Copy link
Contributor Author

Oh sorry, seems that those issues have the seem root cause. It was hard to find proper terms to search for. This description is so far the only one that is not about a login popup though, so it might be a useful addition. Feel free to close this as a duplicate.

@bsclifton
Copy link
Member

Closing as a dupe of #13370

@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 27, 2018
@bsclifton bsclifton added the duplicate Issue has already been reported label Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

2 participants