Unique Device ID's

[gameb0y]

please remove this

WebRTC Media Device Enumeration
Unique Device ID's

http://www.browserleaks.com/webrtc

[luixxiul]

Duping to #260

[luixxiul]

Reopened for Unique Device ID of WebRTC Media Device Enumeration. Should we remove it? cc: @diracdeltas

[diracdeltas]

We can leave this open. Unique device IDs themselves are not a problem, but Brave does not uniquely set them between different browsing sessions, so they can be used for cross-session tracking. cf https://w3c.github.io/mediacapture-main/#def-constraint-deviceId

[diracdeltas]

Test page (try opening in different sessions in brave vs chrome): https://jsfiddle.net/22e4yfvg/

[luixxiul]

Confirmed, they are shared across sessions.

[diracdeltas]

@bridiver are you taking this?

[diracdeltas]

ping on this

[bridiver]

yea, I can look at it. We also need to clear the device id when clearing other session data

[diracdeltas]

thx

[diracdeltas]

this seems to have been automatically fixed in the latest libchromium update. the device ids are not shared between sessions anymore, and they are reset on restart. i'll keep this open to track clearing the device ids when other session data is manually cleared

[diracdeltas]

cf https://chromium.googlesource.com/chromium/src/+/4db1329e005388540eb07429ac97827ca9bc422b

[diracdeltas]

closing this and opening follow-up so QA knows this was actually fixed in 0.12.2. #4157

test plan:

1. go to https://jsfiddle.net/22e4yfvg/ in regular, session, and incognito tabs. the device ids should be different in each.
2. restart browser; the device ID in the regular tab should be different from before.