Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clear "Recently Closed" when clearing history #3287

Closed
luixxiul opened this issue Aug 21, 2016 · 5 comments
Closed

Clear "Recently Closed" when clearing history #3287

luixxiul opened this issue Aug 21, 2016 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 21, 2016

Describe the issue you encountered: "Recently Closed" is not cleared while "browsing history" of Private Data option is enabled.

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7 64 bit
  • Brave Version: 0.11.6 Beta1
  • Steps to reproduce:
    1. Open some pages in tabs and close them
    2. Open about:preferences#security
    3. Enable the option Browsing history
    4. Restart the browser
  • Screenshot if needed:
  • Any related issues: Early manual tests for Win-x64 v0.11.6dev beta1 #3283
@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 21, 2016
@luixxiul
Copy link
Contributor Author

In fact you cannot clear them except by removing either the brave folder or session-store-1 file.

@bbondy bbondy changed the title "Recently Closed" should be cleared while private data option is enabled Clear "Recently Closed" when clearing history Aug 22, 2016
@bbondy
Copy link
Member

bbondy commented Aug 22, 2016

When testing:
Please test both the Browsing history option in preferences and the one from the history menu.
Make sure no other data loss like disappearing bookmarks.

@bbondy
Copy link
Member

bbondy commented Aug 23, 2016

@bradleyrichter why did you re-open this? When things are fixed on master we should close them as usual.

@bradleyrichter
Copy link
Contributor

accidental click? I have no idea...

@bbondy
Copy link
Member

bbondy commented Aug 23, 2016

ok np, thanks! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants