Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Missing 'Toggle Main Menu Bar' in hamburger menu #3311

Closed
alexwykoff opened this issue Aug 22, 2016 · 5 comments
Closed

Missing 'Toggle Main Menu Bar' in hamburger menu #3311

alexwykoff opened this issue Aug 22, 2016 · 5 comments
Labels
bug/good-first-bug duplicate Issue has already been reported

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
As per the spec : #1893 a new menu item should exist on Windows and Linux which allows for the toggling of the main menu. It is not present in the current build.

Expected behavior:
If a user opens the hamburger menu, the menu item should exist and function appropriately.

@alexwykoff alexwykoff added this to the 0.11.6dev milestone Aug 22, 2016
@bbondy
Copy link
Member

bbondy commented Aug 23, 2016

was this in 0.11.5? If not let's kick this out of all milestones.

@bsclifton
Copy link
Member

bsclifton commented Aug 23, 2016

@bradleyrichter @alexwykoff where exactly should it go in the menu? We have this menu item already coded so now it's just a matter of adding it to the burger context menu

Currently, it shows when right clicking on the bookmarks toolbar. Should that one be kept the same?
screen shot 2016-08-23 at 12 24 29 am

[--- Commented from Asana.com
#commenter brad richter
---[aa]

@bsclifton bsclifton removed this from the 0.11.6dev milestone Aug 23, 2016
@bsclifton
Copy link
Member

Removed milestone, per @bbondy's comment. This was not in 0.11.5, this is a new proposal

@alexwykoff
Copy link
Contributor Author

It was in the original specification, so it's not a matter of being in 0.11.5 or a new proposal, but rather matching the design. (#1893)

https://cloud.githubusercontent.com/assets/13509546/15487940/320d51e2-2106-11e6-883f-387baccb5d73.png

That said, I certainly would not call it a showstopper for 0.11.6 and it's perfectly fair to punt to a later time.

@bsclifton
Copy link
Member

Yup, #1893 is the new proposal. I'll close this as a dupe unless we'd like to track individual items

@luixxiul luixxiul added the duplicate Issue has already been reported label Aug 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug/good-first-bug duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

4 participants