Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Esc handler changes windowed / fullscreen mode depending on permissions #3464

Closed
alexwykoff opened this issue Aug 26, 2016 · 1 comment
Closed

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When escaping from fullscreen video, the browser will return to windowed mode if the permissions have been permanently set, but will shift the browser to fullscreen mode if the permission was allowed only once.

Expected behavior:
If a user starts in windowed mode, they should return to windowed mode when they escape from a fullscreen video.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.11.6 pre-beta4
  • Steps to reproduce:
    1. Open a video in full screen ( twitch.tv was what was used during testing), allow for permission once.
    2. Use the Esc key.
    3. Observe the window status.
  • Screenshot if needed:
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.11.6dev milestone Aug 26, 2016
@bridiver
Copy link
Collaborator

that commit also fixes exiting webview fullscreen on tab change and brave/muon@fd4b967 fixes exiting on tab close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants