This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
a few minor things #3554
Merged
a few minor things #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. if `process.env-NODE_ENV === ‘test’` then set the `synopsis` option `minDuration` to 0 msecs 2. if `process.env.LEDGER_PUBLISHER_DEBUG === true` then show how visits are counted 3. better error printing in one case 4. include the `ledger-publisher` code for handling `new Set()`
| @@ -467,16 +465,19 @@ var updatePublisherInfo = () => { | |||
| syncWriter(pathName(publisherPath), data, () => {}) | |||
| syncWriter(pathName(scoresPath), synopsis.allN(), () => {}) | |||
|
|
|||
| if (synopsis.options.minDuration === 0) synopsis.options.minDuration = 8 * msecs.second | |||
There was a problem hiding this comment.
because that is the actual default value, and when the synopsis is written out, i don't want it to be zero, so that when someone starts the browser without process.env.NODE_ENV being test, they won't get surprised... but, i see an easier fix. please stand by.
There was a problem hiding this comment.
@diracdeltas - i think the latest commit simplifies things.
then use `’-test’` as suffix for state files
This was referenced Aug 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.env-NODE_ENV === ‘test’then set thesynopsisoptionminDurationto 0 msecsprocess.env.LEDGER_PUBLISHER_DEBUG === truethen show how visits are counted -- for Significant lag between browser history and ledger listing #3451ledger-publishercode for handlingnew Set()auditor: @diracdeltas