Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reduce package and installer sizes #371

Closed
bbondy opened this issue Jan 28, 2016 · 7 comments
Closed

Reduce package and installer sizes #371

bbondy opened this issue Jan 28, 2016 · 7 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jan 28, 2016

Things like abp-filter-parser-cpp build files that aren't needed are included. We can slim down this installer by a lot.
#4080 #4081 #3193

@bbondy
Copy link
Member Author

bbondy commented Jan 31, 2016

Windows: 130MB -> 84MB
OSX: 103MB -> 68MB
Leaving this open though because there are more ways to reduce the size by a lot.
e65b2e5

@Hrxn
Copy link

Hrxn commented Feb 1, 2016

I didn't directly ask about the size of the installer, my actual question was: Is it bundled with Node, in any form?

@bbondy
Copy link
Member Author

bbondy commented Feb 1, 2016

Thanks for clarifying @Hrxn.
Electron is built using parts of Node for package loading and libchromiumcontent.
Brave is based on Electron.

@bbondy
Copy link
Member Author

bbondy commented Feb 1, 2016

Independent of the previous conversation message. This ticket can be closed when we're smaller than Chrome on both platforms.

Chrome:
OSX for Chrome is 63.1MB
Windows: 49.7MB

Brave:
OSX: 68MB
Windows: 84MB

@luixxiul
Copy link
Contributor

@bbondy How about now?

@bbondy
Copy link
Member Author

bbondy commented May 13, 2016

We can still reduce more but haven't focused on it yet.

@posix4e
Copy link
Contributor

posix4e commented Dec 21, 2016

Perhaps we should build a new more specific issue and close this one?

@bbondy bbondy closed this as completed Dec 21, 2016
@luixxiul luixxiul removed this from the 1.0.0 milestone Dec 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants