Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Blocked script info dialog should be under noScript icon #3757

Closed
srirambv opened this issue Sep 6, 2016 · 7 comments
Closed

Blocked script info dialog should be under noScript icon #3757

srirambv opened this issue Sep 6, 2016 · 7 comments
Labels
feature/navbar needs-mockup A feature which needs design mockup to be implemented. stale suggestion

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 6, 2016

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
Blocked script info window is off location

Expected behavior:
Should be below the blocked script icon

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.0 RC2 (Clean install)
  • Steps to reproduce:
    1. Enable Block scripts in Shields
    2. Visit any site and click on the blocked script icon next to URL bar.
    3. Info window is off position.
  • Screenshot if needed:
    image
  • Any related issues:
@luixxiul luixxiul changed the title Blocked script info window is off location Blocked script info dialog should be under noScript icon Feb 2, 2017
@luixxiul luixxiul added this to the Backlog milestone Feb 2, 2017
@luixxiul luixxiul self-assigned this Feb 2, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jun 4, 2017

I'm guessing it should be like the bookmark hanger, which appears with the arrowUp under the bookmark star icon.

The modal background color is going to be removed since 0.18.x (#9034).

#7989

@luixxiul
Copy link
Contributor

luixxiul commented Jun 6, 2017

@bradleyrichter could I know if you have a mockup of the dialog? I'm wondering if it would look nicer when commonForm is applied to make it like bookmark hanger:

screenshot 2017-06-06 17 01 16

With the arrowUp, it should appear under the noScript icon, which is 🚫 .

@luixxiul
Copy link
Contributor

It would be solved like this way:

screenshot 2017-09-16 12 04 53

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Sep 16, 2017 via email

@luixxiul
Copy link
Contributor

we should retain the normal control styles and perhaps reduce the size of the panel itself

Replacing the checkboxes with switches? it would look fine.

I'd reduce the panel size and adjust it through l10n QA.

@luixxiul
Copy link
Contributor

luixxiul commented Sep 23, 2017

How about this one?

screenshot 2017-09-23 17 04 10

the wording can be improved to close #7377

also Unselect will be changed into Select.

@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@bsclifton
Copy link
Member

@bsclifton bsclifton added the needs-mockup A feature which needs design mockup to be implemented. label Oct 28, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton added the stale label Sep 9, 2018
@bsclifton bsclifton added stale and removed stale labels Sep 9, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/navbar needs-mockup A feature which needs design mockup to be implemented. stale suggestion
Projects
None yet
Development

No branches or pull requests

6 participants