This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
new dialog design for adding funds #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkup
force-pushed
the
add-funds-dialog
branch
from
3cc3b73
to
9354f3b
Compare
| @@ -38,14 +38,15 @@ tableEmptyText=No table data. | |||
| notificationEmptyText=Top publisher visits | |||
| syncEmptyText=Sync settings coming soon. | |||
| bitcoin=Bitcoin | |||
| bitcoinAdd=Use an existing Bitcoin wallet | |||
| bitcoinAdd=Use your existing bitcoin wallet/account | |||
jkup
force-pushed
the
add-funds-dialog
branch
from
9354f3b
to
7855ff3
Compare
jkup
changed the title
jkup
force-pushed
the
add-funds-dialog
branch
from
7855ff3
to
35ce635
Compare
| <div className='bitcoinQRTitle' data-l10n-id='bitcoinQR' /> | ||
| </div> | ||
| } | ||
| get qrcodeOverlayFooter () { |
There was a problem hiding this comment.
i don't think the QR code overlay should show the coinbase logo since it doesn't depend on coinbase at all
There was a problem hiding this comment.
@bradleyrichter how does that sound to you? I was just going off your mock https://cloud.githubusercontent.com/assets/13509546/18232727/0a78554c-728b-11e6-9146-e8196a95e39d.png
|
the case where Coinbase isn't available (for funds > $5/month) needs some CSS love: |
jkup
force-pushed
the
add-funds-dialog
branch
from
35ce635
to
062f260
Compare
|
lgtm, thanks |
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixes #3677 #3484 #3629
Test Plan:
This is still in progress. Just wanted to push a PR so I can get some feedback.