This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix Redhat desktop launcher #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that under RHEL the generated desktop launcher does not have the correct mine types, so Brave can not be set as default browser. This was reported and fixed here #2839 in both Brave and electron-redhat-installer package. However the fixed version of the installer package was never used by Brave. This PR bumps the version so it should work ok now. Fixes #3776 Auditors: @bbondy Test Plan: 1. Install Brave under Fedora 24 and make sure it can be set as default browser from the Default applications menu
|
++ |
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).The problem is that under RHEL the generated desktop launcher does not
have the correct mine types, so Brave can not be set as default browser.
This was reported and fixed here #2839
in both Brave and electron-redhat-installer package. However the fixed version
of the installer package was never used by Brave. This PR bumps the version
so it should work ok now.
Fixes #3776
Auditors:
@bbondy
Test Plan:
browser from the Default applications menu