Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarks menu not updated when adding/removing bookmark folder #4227

Closed
srirambv opened this issue Sep 23, 2016 · 2 comments
Closed

Bookmarks menu not updated when adding/removing bookmark folder #4227

srirambv opened this issue Sep 23, 2016 · 2 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 23, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Deleted folders under bookmark gets removed only after browser restart

Expected behavior:
Deleted folders should be removed from the bookmarks menu with requiring a restart

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x32, x64

  • Brave Version:
    0.12.2. RC2

  • Steps to reproduce:

    1. Create bookmark folders
    2. Delete the bookmark folder from the bookmark bar
    3. Folder shows in bookmark menu, gets removed only after restarting browser
  • Screenshot if needed:
    b1

  • Any related issues:
    Delete bookmark folder won't delete its child items #4124

    cc: @bsclifton

@srirambv srirambv added this to the 0.12.2dev milestone Sep 23, 2016
@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.2dev Sep 23, 2016
@bbondy
Copy link
Member

bbondy commented Sep 23, 2016

I think this was around for a couple versions so moving to 0.12.3.

@bsclifton
Copy link
Member

This specifically is an issue with the menu code- we don't send any windowActions when a bookmark folder is deleted. To confirm, you can also just add another bookmark and that will cause the menu to be rebuilt (which then has the change)

@bsclifton bsclifton changed the title Deleted folders under bookmark gets removed only after browser restart Bookmarks menu not updated when adding/removing bookmark folder Sep 25, 2016
@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants