Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger view counter is incrementing on 404 pages #4246

Closed
alexwykoff opened this issue Sep 23, 2016 · 3 comments
Closed

Ledger view counter is incrementing on 404 pages #4246

alexwykoff opened this issue Sep 23, 2016 · 3 comments
Labels
feature/rewards invalid

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While verifying #4032 and #3759 it was found that the page counter was incrementing on 404 pages.

Expected behavior:
If a user visits a site and receives a unacceptable status code per #3759, the timer AND the counter should not be effected.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.12.2 rc2
  • Steps to reproduce:
  • Visit https://clifton.io
  • Stay on page for a while
  • Confirm time spent is incremented
  • Visit https://clifton.io/404
  • Stay on page for a while
  • Confirm time spent is not incremented and that the view counter is not incremented
  • Screenshot if needed:
    screen shot 2016-09-23 at 2 40 26 pm
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.2dev milestone Sep 23, 2016
@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.2dev Sep 24, 2016
@bbondy
Copy link
Member

bbondy commented Sep 24, 2016

moving to 0.12.3

@alexwykoff
Copy link
Contributor Author

could not reproduce, closing

@luixxiul luixxiul removed this from the 0.12.3dev milestone Sep 25, 2016
@bsclifton
Copy link
Member

May have been fixed w/ 1d65e0b

@bsclifton bsclifton mentioned this issue Sep 25, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/rewards invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @bsclifton