This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixed draggable areas of window. #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we ship the red/yellow? 😛 |
|
Still investigating why the min/max/close are buttons are not clickable when magnification is at 150%. I created a bare bones electron project to help understand why and have reproduced some drag issues |
|
Opened an upstream issue electron/electron#7347 Looking through the electron source now to collect more info and understand the root cause |
|
This patch can be accepted as soon as brave/muon#63 is merged! 😄 @bbondy - if you were able to review the electron change, apply it, and then re-test this patch you should be pleasantly surprised 😄 |
- parent item marks all as draggable - child items exclude themself as needed - parent level draggable is disregarded if modal is open, menu is open, etc (using shouldAllowWindowDrag) Other touch-ups: - tabs bar is now draggable (no longer right-clickable) - caption button drag and surrounding area is correct now - after acceptance of electron PR, corners are easy to click (hit testing) Fixes #4235 Fixes #4144 Depends on brave/muon#63 Auditors: @bbondy @jonathansampson
|
++ |
This was referenced Sep 27, 2016
This was referenced Oct 2, 2016
|
Note for QA: Be sure to check cursor-in-address bar vs not. These two different modes may have results you did not expect : |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixed draggable areas of window.
Fixes #4235
Auditors: @bbondy
Here's a live demo on Windows 7