Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix suggestions list overflow (unintentionally introduced when fixing resizing) #4299

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Fix suggestions list overflow (unintentionally introduced when fixing resizing) #4299

merged 1 commit into from
Sep 26, 2016

Conversation

jonathansampson
Copy link
Collaborator

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

While the overflow: hidden resolved the titlebar issue, it did so at
the cost of clipping suggestions. This approach achieves the desired
results, without clipping.

Fixes #4298

Auditors: @bsclifton, @bbondy

Before:

image

After:

image

While the `overflow: hidden` resolved the titlebar issue, it did so at
the cost of clipping suggestions. This approach achieves the desired
results, without clipping.
@jonathansampson jonathansampson added bug design A design change, especially one which needs input from the design team. OS/Windows feature/titlebar labels Sep 26, 2016
@bsclifton
Copy link
Member

Tested in my branch, LGTM 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug design A design change, especially one which needs input from the design team. feature/titlebar OS/Windows QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions Clipped
5 participants