Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression: Brave Payments : Ledger headers should not disappear while scrolling. #4461

Closed
alexwykoff opened this issue Oct 3, 2016 · 3 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Per #4085 the ledger headers should stay at the top while the individual publisher information should scroll for long lists.

Expected behavior:
If a user has many publishers in their ledger history, when they scroll, the headers should remain visible.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on Win7 x64
  • Brave Version:
    0.12.3 RC6
  • Steps to reproduce:
    1. With a clean install, enable Brave Payments and visit A LOT of sites.
    2. On the Brave Payments preference pane, scroll down.
    3. Observe that the headers remain fixed at the top of the columns and do not disappear.
  • Screenshot if needed:
    ledger_headers
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.4dev milestone Oct 3, 2016
@jkup jkup self-assigned this Oct 3, 2016
@jkup
Copy link
Contributor

jkup commented Oct 4, 2016

I think this is fixed now that the sticky header patch is in. Can you verify on your end @alexwykoff?

@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

Marking as closed since the expectation is that it's fixed. (QA will re-open if a bug).
@jkup do you have the changeset you think it was fixed in?

@bbondy bbondy closed this as completed Oct 4, 2016
@jkup
Copy link
Contributor

jkup commented Oct 4, 2016

@bbondy this PR #4395

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants