Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fa-icons on about pages are not aligned consistently #6137

Closed
luixxiul opened this issue Dec 11, 2016 · 1 comment
Closed

Fa-icons on about pages are not aligned consistently #6137

luixxiul opened this issue Dec 11, 2016 · 1 comment
Labels
polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 11, 2016 •
edited
Loading

Describe the issue you encountered: Fa-icons on about pages are not aligned consistently

screenshot 2016-12-11 23 09 56

the icon for the new tab should have the same width.

screenshot 2016-12-11 23 51 51

the info icons shoule be indented.

screenshot 2016-12-11 23 51 57

line-height should be set.

Expected behavior:
screenshot 2016-12-11 23 54 51

screenshot 2016-12-11 23 54 32

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version: master branch

  • Any related issues:
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Dec 11, 2016
@luixxiul luixxiul mentioned this issue Dec 11, 2016
Merged
4 tasks
@bbondy bbondy added this to the 0.12.15 milestone Dec 13, 2016
This was referenced Dec 13, 2016
Closed
Closed
Closed
Closed
@luixxiul luixxiul modified the milestones: 0.13.0, 0.12.15 Dec 14, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test plan: #6138 (comment)

This was referenced Jan 18, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @srirambv